Do queries on background go routines which backoff #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
Status: testing it, and plan on moving the backoff on chunk put into the chunk store using the same mechanism. |
Contributor
Author
|
(Testing locally. Worked first time, so I wrote some unit tests) |
jml
approved these changes
Nov 24, 2016
Contributor
jml
left a comment
jml
left a comment
There was a problem hiding this comment.
I tried, but couldn't manage to do a thorough review.
|
|
||
| // Not exported as only used by tests to inject mocks | ||
| dynamodb dynamodbClient | ||
| s3 s3Client |
Contributor
There was a problem hiding this comment.
It would be better to have a separate function for creating an AWSStore that takes a dynamodbClient, s3client, and chunk Cache directly. Separates the concern of parsing & validating config from constructing a usable store.
Contributor
Author
There was a problem hiding this comment.
I'll do a techdebt ticket to split this up; we basically have the beginning of our own dynamodb client now.
chunk/chunk_store.go
Outdated
| continue | ||
| } | ||
|
|
||
| // If we get provisionedThroughputExceededException, then no items we're processed, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, don't let the client library do retires for us, so we can correctly gauge capacity usage etc.
Part of #132