Add global limit to the max series per user and metric #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Oct 25, 2019
pracucci
force-pushed
the
add-global-max-series-per-user-and-metric
branch
from
28e8ea0 to
368588a
Compare
pracucci
force-pushed
the
add-global-max-series-per-user-and-metric
branch
2 times, most recently
from
ef95857 to
53404e1
Compare
gouthamve
approved these changes
Oct 28, 2019
pracucci
force-pushed
the
add-global-max-series-per-user-and-metric
branch
from
d289680 to
049b2bd
Compare
pracucci
force-pushed
the
add-global-max-series-per-user-and-metric
branch
2 times, most recently
from
e9cae33 to
d0ac12c
Compare
tomwilkie
approved these changes
Oct 31, 2019
- `-ingester.max-global-series-per-user` - `-ingester.max-global-series-per-metric` Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…o create a new ring client for the ingesters Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…eded Signed-off-by: Marco Pracucci <[email protected]>
…unters and the ring desc is nil Signed-off-by: Marco Pracucci <[email protected]>
…s lifecycler updateCounters() Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…make it more generic Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
add-global-max-series-per-user-and-metric
branch
from
d0ac12c to
c0ef755
Compare
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to this design doc, in this PR I propose to introduce a global limit on the maximum number of series per user and metric.
The global limit has been implemented as a local (per-ingester) limit configured based on the number of ingesters in the cluster + replication factor.
Notes:
-distributor.shard-by-all-labelsconfig option as well, otherwise it doesn't know it. Not super nice, but I haven't find a better way to do it (better ideas?)The ingester now depends on the read ring, to count the number of ingesters across the cluster0