Added user label to cortex_ingester_memory_series metric #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
|
Approving, but we really need to find a different way of having access to this information. Adding user label to more metrics is a cause to metrics explosion :-( |
pstibrany
approved these changes
Nov 12, 2019
Signed-off-by: Marco Pracucci <[email protected]>
|
Closing cause - with a lower resolution - should be able to approximate via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the PR #1760 I've introduced a global limit on the max series per user and metric, but unfortunately we don't have a per-tenant metric to give us an overview on the current per-tenant series utilization, in order to fine tune the global limit.
For this reason, in this PR I'm suggesting to add the
userlabel to thecortex_ingester_memory_seriesmetric, like we already have forcortex_ingester_memory_series_created_totalandcortex_ingester_memory_series_removed_total.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]