-
Notifications
You must be signed in to change notification settings - Fork 816
Compile code in vendor dir; don't download modules again #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bryan Boreham <[email protected]>
Doesn't seem to work at CircleCI:
|
This is how Go 1.14 will work out of the box, once we switch to it. |
Maybe I should just do Go 1.14 instead. |
Probably replaced by #2480 |
I don't think so. It's a step forward, but doesn't closes this. In order to get what we want we need |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Switching to |
@bboreham I hope you don't mind if I close this PR. We already switched to Go 1.14. |
What this PR does:
Tells Go to use the code we have checked in under
vendor
.Which issue(s) this PR fixes:
Fixes #1710
Fixes #1795
Checklist
N/A