Skip to content

Add active series to all user stats page #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

songjiayang
Copy link
Contributor

@songjiayang songjiayang commented Nov 17, 2022

Signed-off-by: songjiayang [email protected]

What this PR does:

Add active_series to all_user_stats page.

Which issue(s) this PR fixes:
Fixes #4917

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

songjiayang added a commit to songjiayang/cortex that referenced this pull request Nov 17, 2022
@songjiayang songjiayang force-pushed the add_active_series_to_stats branch from 02ae79e to 0017284 Compare November 17, 2022 14:22
songjiayang added a commit to songjiayang/cortex that referenced this pull request Nov 17, 2022
@songjiayang songjiayang force-pushed the add_active_series_to_stats branch from 0017284 to 93b4a83 Compare November 17, 2022 16:25
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 17, 2022
@alanprot
Copy link
Member

NIce!! :D

Can you fix the lint?

songjiayang added a commit to songjiayang/cortex that referenced this pull request Nov 19, 2022
@songjiayang songjiayang force-pushed the add_active_series_to_stats branch from 93b4a83 to f0dd352 Compare November 19, 2022 09:20
@songjiayang
Copy link
Contributor Author

Thank @alanprot, I have changed protoc-gen-gogoslick version from v1.3.2 to v1.3.0 on my local, code generated looks fine. review again please.

@songjiayang songjiayang force-pushed the add_active_series_to_stats branch from f0dd352 to f06ab83 Compare November 22, 2022 02:51
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks great.

@alvinlin123 alvinlin123 merged commit de25e5b into cortexproject:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add active series metric to ingester stats page
4 participants