Skip to content

Add active series to all user stats page #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## master / unreleased

* [FEATURE] Ingester: Add active series to all_user_stats page. #4972

## 1.14.0 in progress

**This release removes support for chunks storage. See below for more.**
Expand Down
9 changes: 7 additions & 2 deletions pkg/distributor/distributor.go
Original file line number Diff line number Diff line change
Expand Up @@ -1189,10 +1189,13 @@ func (d *Distributor) UserStats(ctx context.Context) (*UserStats, error) {
totalStats.APIIngestionRate += r.ApiIngestionRate
totalStats.RuleIngestionRate += r.RuleIngestionRate
totalStats.NumSeries += r.NumSeries
totalStats.ActiveSeries += r.ActiveSeries
}

totalStats.IngestionRate /= float64(d.ingestersRing.ReplicationFactor())
totalStats.NumSeries /= uint64(d.ingestersRing.ReplicationFactor())
factor := d.ingestersRing.ReplicationFactor()
totalStats.IngestionRate /= float64(factor)
totalStats.NumSeries /= uint64(factor)
totalStats.ActiveSeries /= uint64(factor)

return totalStats, nil
}
Expand Down Expand Up @@ -1231,6 +1234,7 @@ func (d *Distributor) AllUserStats(ctx context.Context) ([]UserIDStats, error) {
s.APIIngestionRate += u.Data.ApiIngestionRate
s.RuleIngestionRate += u.Data.RuleIngestionRate
s.NumSeries += u.Data.NumSeries
s.ActiveSeries += u.Data.ActiveSeries
perUserTotals[u.UserId] = s
}
}
Expand All @@ -1245,6 +1249,7 @@ func (d *Distributor) AllUserStats(ctx context.Context) ([]UserIDStats, error) {
APIIngestionRate: stats.APIIngestionRate,
RuleIngestionRate: stats.RuleIngestionRate,
NumSeries: stats.NumSeries,
ActiveSeries: stats.ActiveSeries,
},
})
}
Expand Down
2 changes: 2 additions & 0 deletions pkg/distributor/http_admin.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const tpl = `
<tr>
<th>User</th>
<th># Series</th>
<th># Active Series</th>
<th>Total Ingest Rate</th>
<th>API Ingest Rate</th>
<th>Rule Ingest Rate</th>
Expand All @@ -40,6 +41,7 @@ const tpl = `
<tr>
<td>{{ .UserID }}</td>
<td align='right'>{{ .UserStats.NumSeries }}</td>
<td align='right'>{{ .UserStats.ActiveSeries }}</td>
<td align='right'>{{ printf "%.2f" .UserStats.IngestionRate }}</td>
<td align='right'>{{ printf "%.2f" .UserStats.APIIngestionRate }}</td>
<td align='right'>{{ printf "%.2f" .UserStats.RuleIngestionRate }}</td>
Expand Down
1 change: 1 addition & 0 deletions pkg/distributor/http_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ type UserStats struct {
NumSeries uint64 `json:"numSeries"`
APIIngestionRate float64 `json:"APIIngestionRate"`
RuleIngestionRate float64 `json:"RuleIngestionRate"`
ActiveSeries uint64 `json:"activeSeries"`
}

// UserStatsHandler handles user stats to the Distributor.
Expand Down
207 changes: 124 additions & 83 deletions pkg/ingester/client/ingester.pb.go

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions pkg/ingester/client/ingester.proto
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ message UserStatsResponse {
uint64 num_series = 2;
double api_ingestion_rate = 3;
double rule_ingestion_rate = 4;
uint64 active_series = 5;
}

message UserIDStatsResponse {
Expand Down
13 changes: 10 additions & 3 deletions pkg/ingester/ingester.go
Original file line number Diff line number Diff line change
Expand Up @@ -1553,7 +1553,7 @@ func (i *Ingester) UserStats(ctx context.Context, req *client.UserStatsRequest)
return &client.UserStatsResponse{}, nil
}

return createUserStats(db), nil
return createUserStats(db, i.cfg.ActiveSeriesMetricsEnabled), nil
}

// AllUserStats returns ingestion statistics for all users known to this ingester.
Expand All @@ -1573,20 +1573,27 @@ func (i *Ingester) AllUserStats(_ context.Context, _ *client.UserStatsRequest) (
for userID, db := range users {
response.Stats = append(response.Stats, &client.UserIDStatsResponse{
UserId: userID,
Data: createUserStats(db),
Data: createUserStats(db, i.cfg.ActiveSeriesMetricsEnabled),
})
}
return response, nil
}

func createUserStats(db *userTSDB) *client.UserStatsResponse {
func createUserStats(db *userTSDB, activeSeriesMetricsEnabled bool) *client.UserStatsResponse {
apiRate := db.ingestedAPISamples.Rate()
ruleRate := db.ingestedRuleSamples.Rate()

var activeSeries uint64
if activeSeriesMetricsEnabled {
activeSeries = uint64(db.activeSeries.Active())
}

return &client.UserStatsResponse{
IngestionRate: apiRate + ruleRate,
ApiIngestionRate: apiRate,
RuleIngestionRate: ruleRate,
NumSeries: db.Head().NumSeries(),
ActiveSeries: activeSeries,
}
}

Expand Down
2 changes: 2 additions & 0 deletions pkg/ingester/ingester_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3193,6 +3193,7 @@ func Test_Ingester_AllUserStats(t *testing.T) {
NumSeries: 3,
ApiIngestionRate: 0.2,
RuleIngestionRate: 0,
ActiveSeries: 3,
},
},
{
Expand All @@ -3202,6 +3203,7 @@ func Test_Ingester_AllUserStats(t *testing.T) {
NumSeries: 2,
ApiIngestionRate: 0.13333333333333333,
RuleIngestionRate: 0,
ActiveSeries: 2,
},
},
}
Expand Down