Rename failure metrics #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow. What. I was wondering how this was even possible, given that the metrics registry should complain about two metrics with the same name. Turns out, I just didn't even collect those metrics at all :( Shame on me. Could you also add the missing four ingester metrics to the |
|
Yeah, was going to do that in a different PR but can do it here also. |
Fixes #59
juliusv
reviewed
Oct 24, 2016
| "The percent ownership of the ring by ingester", | ||
| []string{"ingester"}, nil, | ||
| ), | ||
| ingesterTotalDesc: prometheus.NewDesc( | ||
| "prometheus_distributor_ingesters_total", | ||
| "prism_distributor_ingesters_total", |
There was a problem hiding this comment.
Sorry, while you're at it: this shouldn't have a _total suffix, as it's a gauge, not a counter. Just prism_distributor_ingesters.
juliusv
reviewed
Oct 24, 2016
| "Number of ingesters in the ring", | ||
| nil, nil, | ||
| ), | ||
| tokensTotalDesc: prometheus.NewDesc( | ||
| "prometheus_distributor_tokens_total", | ||
| "prism_distributor_tokens_total", |
|
👍 otherwise. |
tomwilkie
added a commit
that referenced
this pull request
Jan 21, 2017
b783528 Tweak test script so it can be run on a mca a3b18bf Merge pull request #65 from weaveworks/fix-integration-tests ecb5602 Fix integration tests f9dcbf6 ... without tab (clearly not my day) a6215c3 Add break I forgot 0e6832d Remove incorrectly added tab eb26c68 Merge pull request #64 from weaveworks/remove-test-package-linting f088e83 Review feedback 2c6e83e Remove test package linting git-subtree-dir: tools git-subtree-split: b783528b75f6ba52a51832bd087bd8347b26f131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
This change is