More visibility on ingesters #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #59
If we're only going to error anyway, might as well do it quickly.
jml
force-pushed
the
60-more-visibility
branch
from
b57aef3 to
c891ab5
Compare
juliusv
reviewed
Oct 24, 2016
| @@ -263,6 +263,10 @@ func (d *Distributor) Query(ctx context.Context, from, to model.Time, matchers . | |||
| return err | |||
| } | |||
|
|
|||
| if len(ingesters) < d.cfg.MinReadSuccesses { | |||
| return fmt.Errorf("Could only find %d ingesters for query. Need at least %d", len(ingesters), d.cfg.MinReadSuccesses) | |||
There was a problem hiding this comment.
Start error strings lower-cased.
|
👍 besides nit |
juliusv
reviewed
Oct 24, 2016
| ch <- prometheus.MustNewConstMetric( | ||
| d.ingestersAlive, | ||
| prometheus.GaugeValue, | ||
| float64(len(d.cfg.Ring.GetAll(d.cfg.HeartbeatTimeout))), |
There was a problem hiding this comment.
This metric might strengthen the argument of moving the heartbeat timeout into the ring completely. We have the total ingesters metric in the ring, but the one about alive ones in the distributor, bleh. Just something to keep in mind though, fine for now.
There was a problem hiding this comment.
As long as the Ring in inextricably tied to IngesterDesc, sure, why not?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this fixes #60. Gives us a measure of non-dead ingesters.
Also, I noticed that the reason we'd be getting
nilerrors on query failures is that we haven't got enough ingesters, so I added an early failure path with a better error message.I thought about adding a crappy status page at
/ringzor something, but I would have had to pierce through a layer or two of abstraction and decided that it wasn't worth the effort. Happy to revisit if people think otherwise.Assumes #65
This change is