Log outstanding writes in DynamoDB #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jml
reviewed
Mar 7, 2018
| @@ -731,6 +734,7 @@ func (a storageClient) putS3Chunk(ctx context.Context, key string, buf []byte) e | |||
| }) | |||
| } | |||
|
|
|||
| // Slice of values returned; map key is attribute name | |||
There was a problem hiding this comment.
Thanks for this & similar comments. What do you think about a follow-up PR replacing string with typedefs?
|
Sadly I had failed to observe it crashing very occasionally; there are entries which have a hash key and range key but no value. I have modified the code to be paranoid about all three. |
|
Still LGTM. |
jml
reviewed
Mar 7, 2018
| } | ||
| if valueAttr, ok := item[valueKey]; ok { | ||
| value = valueAttr.B | ||
| } |
There was a problem hiding this comment.
Feels like something that could have been statically checked for. Oh well.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help investigate #733. From existing log lines I know we very commonly get just 1 item remaining at the timeout, so I want to know what it is.
Also some drive-by comments because I needed to figure out what was going on.