Skip to content

Log outstanding writes in DynamoDB #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2018
Merged

Log outstanding writes in DynamoDB #734

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e4615c
Log DynamoDB write items left outstanding
bboreham Mar 5, 2018
381656b
Add some comments on data types
bboreham Mar 5, 2018
6de49e7
Crash less
bboreham Mar 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions pkg/chunk/aws/storage_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@ func (a storageClient) BatchWrite(ctx context.Context, input chunk.WriteBatch) e
}

if valuesLeft := outstanding.Len() + unprocessed.Len(); valuesLeft > 0 {
if valuesLeft < 4 { // protect against logging lots of data
level.Info(util.Logger).Log("msg", "DynamoDB BatchWrite values left", "count", valuesLeft, "outstanding", outstanding, "unprocessed", unprocessed)
}
return fmt.Errorf("failed to write chunk, %d values remaining: %s", valuesLeft, backoff.Err())
}
return backoff.Err()
Expand Down Expand Up @@ -731,6 +734,7 @@ func (a storageClient) putS3Chunk(ctx context.Context, key string, buf []byte) e
})
}

// Slice of values returned; map key is attribute name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this & similar comments. What do you think about a follow-up PR replacing string with typedefs?

type dynamoDBReadResponse []map[string]*dynamodb.AttributeValue

func (b dynamoDBReadResponse) Len() int {
Expand All @@ -749,6 +753,7 @@ func (b dynamoDBReadResponse) Value(i int) []byte {
return chunkValue.B
}

// map key is table name; value is a slice of things to 'put'
type dynamoDBWriteBatch map[string][]*dynamodb.WriteRequest

func (b dynamoDBWriteBatch) Len() int {
Expand Down Expand Up @@ -795,6 +800,31 @@ func (b dynamoDBWriteBatch) TakeReqs(from dynamoDBWriteBatch, max int) {
}
}

func (b dynamoDBWriteBatch) String() string {
buf := &bytes.Buffer{}
for table, reqs := range b {
for _, req := range reqs {
item := req.PutRequest.Item
hash := ""
if hashAttr, ok := item[hashKey]; ok {
if hashAttr.S != nil {
hash = *hashAttr.S
}
}
var rnge, value []byte
if rangeAttr, ok := item[rangeKey]; ok {
rnge = rangeAttr.B
}
if valueAttr, ok := item[valueKey]; ok {
value = valueAttr.B
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like something that could have been statically checked for. Oh well.

fmt.Fprintf(buf, "%s: %s,%.32s,%.32s; ", table, hash, rnge, value)
}
}
return buf.String()
}

// map key is table name
type dynamoDBReadRequest map[string]*dynamodb.KeysAndAttributes

func (b dynamoDBReadRequest) Len() int {
Expand Down