Skip to content

chore: normaliza repository url #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenphi merged 5 commits into from
Dec 16, 2025
Merged

chore: normaliza repository url #927

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c3a686
chore: normaliza repository url
tenphi Dec 12, 2025
c263cad
chore: update github actions
tenphi Dec 12, 2025
5202835
fix: remove environment from canary publish job for trusted publishing
tenphi Dec 12, 2025
6ae2c29
chore: update github actions
tenphi Dec 15, 2025
9adeca4
chore: update github actions * 2
tenphi Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ jobs:
- name: Update npm for trusted publishing
run: npm install -g npm@latest

- name: Verify npm version and OIDC availability
run: |
echo "npm version: $(npm --version)"
echo "OIDC available: ${{ env.ACTIONS_ID_TOKEN_REQUEST_URL != '' }}"
Copy link

@cursor cursor bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: OIDC availability check always evaluates to false

The OIDC verification step uses ${{ env.ACTIONS_ID_TOKEN_REQUEST_URL != '' }} to check OIDC availability, but this will always evaluate to false. The ACTIONS_ID_TOKEN_REQUEST_URL is a runtime environment variable injected by GitHub Actions infrastructure, not accessible via the workflow's env context (which only includes variables defined in env: blocks). To check this variable, shell syntax like $ACTIONS_ID_TOKEN_REQUEST_URL must be used instead of the expression context. The diagnostic output will always show "OIDC available: false" regardless of actual OIDC availability, providing misleading information during troubleshooting.

Additional Locations (1)

Fix in Cursor Fix in Web


- name: Install dependencies
run: pnpm install

Expand All @@ -81,9 +86,12 @@ jobs:
- name: Build project
run: pnpm build

- name: Clear .npmrc auth token (use OIDC instead)
run: npm config delete //registry.npmjs.org/:_authToken || true

- name: Publish canary to npm
working-directory: ./dist
run: npm publish --access public --tag pr_${{ inputs.pr-number }}
run: npm publish --access public --tag pr_${{ inputs.pr-number }} --provenance

- name: Comment PR
uses: actions/github-script@v6
Expand Down Expand Up @@ -142,9 +150,17 @@ jobs:
- name: Update npm for trusted publishing
run: npm install -g npm@latest

- name: Verify npm version and OIDC availability
run: |
echo "npm version: $(npm --version)"
echo "OIDC available: ${{ env.ACTIONS_ID_TOKEN_REQUEST_URL != '' }}"

- name: Install Dependencies
run: pnpm install

- name: Clear .npmrc auth token (use OIDC instead)
run: npm config delete //registry.npmjs.org/:_authToken || true

- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@v1
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "UIKit for Cube Projects",
"repository": {
"type": "git",
"url": "https://github.com/cube-js/cube-ui-kit.git"
"url": "git+https://github.com/cube-js/cube-ui-kit.git"
},
"module": "dist/es/index.js",
"types": "dist/types/index.d.ts",
Expand Down
Loading