You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of #1564, we determine whether we should remove whitespace in part based on whether the remaining adjacent token is an opening / closing pair. This mostly works, but has a couple problems:
We duplicate our source of truth about which tokens are considered opening / closing pairs
The logic breaks down in complex cases, eg when it's not obvious whether a " is opening or closing (see test case below)
The solution
We should find a way to leverage the code we use in surrounding pairs to determine if a token is opening or closing
The problem
As of #1564, we determine whether we should remove whitespace in part based on whether the remaining adjacent token is an opening / closing pair. This mostly works, but has a couple problems:
"
is opening or closing (see test case below)The solution
We should find a way to leverage the code we use in surrounding pairs to determine if a token is opening or closing
Dependencies
surroundingPair
to use a scope handler #1061Test cases to add
The following test case fails today, but should pass:
The text was updated successfully, but these errors were encountered: