Make token removal range less aggressive #1564

AndreasArvidsson · 2023-07-02T21:12:36Z

Checklist

pokey

🙌

pokey · 2023-07-06T17:36:02Z

...ine/src/processTargets/targetUtil/insertionRemovalBehaviors/TokenInsertionRemovalBehavior.ts

+const leadingDelimiters = ['"', "'", "(", "[", "{", "<"];
+const trailingDelimiters = ['"', "'", ")", "]", "}", ">", ",", ";", ":"];


Filed #1590 to track determining opening / closing properly. What you have here is strictly better than what we do today, so I'm fine with it

Make token removal range less aggressive

071a172

AndreasArvidsson requested a review from pokey as a code owner July 2, 2023 21:12

AndreasArvidsson and others added 3 commits July 2, 2023 23:16

update comment

e46ff0b

cleanup

790a476

Improve doc string

038f8c1

pokey mentioned this pull request Jul 6, 2023

Leverage same mechanism used by surrounding pairs in token whitespace removal logic #1590

Open

Add testcase

08d0abd

pokey approved these changes Jul 6, 2023

View reviewed changes

pokey enabled auto-merge July 6, 2023 18:21

pokey added this pull request to the merge queue Jul 6, 2023

Merged via the queue into main with commit b1f084e Jul 6, 2023

pokey deleted the token-removal-range branch July 6, 2023 18:47

pokey added the bug Something isn't working label Aug 15, 2023

		const leadingDelimiters = ['"', "'", "(", "[", "{", "<"];
		const trailingDelimiters = ['"', "'", ")", "]", "}", ">", ",", ";", ":"];