-
-
Notifications
You must be signed in to change notification settings - Fork 84
Change name
scope in scm
language to include the @
#1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
|
Update from discussion:
Note that this makes drink, pour, and change inconvenient due to missing In the future, we may want to get fancy and include the For "access",
|
Fixes #1923 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
Fixes cursorless-dev#1923 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
If I have the following code:
(where
|
is my cursor), I want to be able to say"bring name cap"
, but that results inrather than the desired
I think we were trying to be too fancy. I'd be inclined to just include the
@
in thename
scope, and stop using@
as insertion delimiterThe drawback is we wouldn't get a
@
when we say "pour name" or "change name"Note that we could get something like this in the future where we'd support
"bring name cap to this"
if we had #1631, but that's still more verbose than"bring name cap"
If we decide to go this route, we should prob also include the
.
in"access"
(#1519)The text was updated successfully, but these errors were encountered: