Skip to content

Include @ in name for scm language #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2023
Merged

Include @ in name for scm language #1927

merged 1 commit into from
Oct 5, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Oct 3, 2023 •
edited
Loading

Fixes #1923

Checklist

  • I have added tests
  • [-] I have updated the docs and cheatsheet
  • [-] I have not broken the cheatsheet

@pokey pokey marked this pull request as ready for review October 3, 2023 17:15
AndreasArvidsson
AndreasArvidsson approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@AndreasArvidsson AndreasArvidsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. By the way are we getting tired of manually having to disable all checkboxes for every pull request where they are not relevant?

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Oct 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 5, 2023
@pokey
Copy link
Member Author

pokey commented Oct 5, 2023 •
edited
Loading

By the way are we getting tired of manually having to disable all checkboxes for every pull request where they are not relevant?

Of course 😄. Got any better ideas?

Tho to be clear, in this case I forgot 😅

@pokey pokey added this pull request to the merge queue Oct 5, 2023
@AndreasArvidsson
Copy link
Member

By the way are we getting tired of manually having to disable all checkboxes for every pull request where they are not relevant?

Of course 😄. Got any better ideas?

Tho to be clear, in this case I forgot 😅

Unfortunately not. I was just wondering because quite a few of your pull requests lately have had unfinished tasks. I would not be against revisiting if we actually need these if people anyhow just forget them. Unfortunately I can't really come up with a better solution.

Merged via the queue into main with commit 4ec5b95 Oct 5, 2023
@pokey pokey deleted the pokey/include-in-name-for-scm-language branch October 5, 2023 05:52
@pokey
Copy link
Member Author

pokey commented Oct 5, 2023 •
edited
Loading

I do think they are helpful. For example, I forgot to test the cheatsheet on the "access" PR until you mentioned the checkboxes here, and that PR very well could have broken the cheatsheet

Please feel free to nag me if I forget to check / scratch out the boxes 😊. I'll try to be better about doing so

fidgetingbits pushed a commit to fidgetingbits/cursorless that referenced this pull request Nov 3, 2023
@pokey
Include @ in name for scm language (cursorless-dev#1927)
c538a23 
Fixes cursorless-dev#1923



## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet
@pokey pokey mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change name scope in scm language to include the @
2 participants
@pokey @AndreasArvidsson