Migrate to a pnpm monorepo #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
force-pushed
the
pokey/pnpm-workspace
branch
from
3f552a7 to
faacb15
Compare
Base automatically changed from
pokey/disallow-type-import-exceptions
to
main
February 28, 2023 12:52
pokey
force-pushed
the
pokey/pnpm-workspace
branch
12 times, most recently
from
abec685 to
efd5c50
Compare
pokey
force-pushed
the
pokey/pnpm-workspace
branch
2 times, most recently
from
60e86b1 to
e44b9a2
Compare
1 task
pokey
force-pushed
the
pokey/pnpm-workspace
branch
from
b0fdf7e to
cdef473
Compare
This was referenced Mar 13, 2023
pokey
force-pushed
the
pokey/pnpm-workspace
branch
2 times, most recently
from
14694c7 to
0405fb5
Compare
pokey
commented
Mar 16, 2023
| # Cursorless first and using a special extension id to break update chain | ||
|
|
||
| # 1. Uninstall production cursorless | ||
| code --uninstall-extension pokey.cursorless || echo "Cursorless not currently installed" |
There was a problem hiding this comment.
Turns out this flag doesn't do what we thought it did; it just tries to launch vscode with the extension disabled; it doesn't disable the extension everywhere. Leaving it as uninstall cc/ @AndreasArvidsson
pokey
commented
Mar 16, 2023
pokey
commented
Mar 16, 2023
pokey
commented
Mar 16, 2023
pokey
commented
Mar 16, 2023
|
ok @auscompgeek I split out requested pieces into #1327, and pulled out the missing pieces you needed for #1322 and added them there |
This was referenced Mar 20, 2023
|
Ok everything from review session addressed except for comment re removing deps from docs package; see response there. Captured changes in 563b872. We need to merge #1322 and #1327 then I think this one is ready to go. lmk what you think cc/ @AndreasArvidsson @auscompgeek |
pokey
force-pushed
the
pokey/base/pnpm-workspace
branch
from
3b49d86 to
eb794e9
Compare
pokey
force-pushed
the
pokey/pnpm-workspace
branch
from
e4e3281 to
563b872
Compare
AndreasArvidsson
pushed a commit
that referenced
this pull request
Mar 20, 2023
- Split off of #1281 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
|
Looks good! |
pokey
added a commit
that referenced
this pull request
Mar 21, 2023
Extracted from #1281 with fixes - [x] fix `takeSnapshot` taking `vscode.Clipboard` ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet --------- Co-authored-by: Pokey Rule <[email protected]>
pokey
force-pushed
the
pokey/pnpm-workspace
branch
from
563b872 to
1e1090f
Compare
pokey
force-pushed
the
pokey/pnpm-workspace
branch
from
1e1090f to
d26d5ae
Compare
|
I'm not going to reread over three thousand files. Based on the walkthrough we have had and the latest changes I have reviewed I'm happy. |
AndreasArvidsson
approved these changes
Mar 21, 2023
pokey
added a commit
that referenced
this pull request
Mar 23, 2023
The test case recorder broke in #1281 due to the fact we're now launching extension in subdirectory called `dist` rather than top-level repo. This PR fixes it ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thenable=>Promise; tweak clipboard mock #1322typeannotations to tree-sitter imports #1327Checklist
internalmodulesMake sure this PR doesn't break doc links; see Fix test fixture upgrade scripts #942 (comment)There's no way to avoid these links getting broken if we upgrade typedoc; filed Fix links stripped from docs during Typedoc link resolution #1304 to track@cursorless/cursorless-vscodein thepackage.jsonchecked into source controlcursorless(see fixme in itsindex.ts)Desiderata
Correctly flagging errors
D1: It is a compile error to import external packages that are not listed inpackage.jsonD1.1:vscode(for some reason this one behaves strangely)D1.2: Other packagesD2: It is not a compile error to import from local packages that you depend on, using our preferred syntax (eg@cursorless/foo)D3: It is a compile error to import from local packages that you depend on, not using our preferred syntax (eg../foo)D4: It is a compile error to import from local packages that you do not depend on, eitherD4.1: using our non-preferred syntax (eg../packages/foo), orD4.2: using preferred syntax (eg@cursorless/foo)D5: It is a compile error to import from anything other thanindex.tsin another moduleD5.1: no@cursorless/foo/barD5.2: no../foo/bara: Even if you depend on the moduleb: Even ifbarwas re-exported infoo/index.ts. In that case it should be required to import@cursorless/foo. Untested, but probably works, and I ran out of steam 😅D6: It is not a compile error to import external packages listed inpackage.jsonD6.1:vscode(for some reason this one behaves strangely)D6.2: Other packagesAuto-import
D7: Auto-import doesn't import from external packages not listed inpackage.jsonD7.1:vscode(for some reason this one behaves strangely)D7.2: Other packagesD8: Auto-import imports from external packages listed inpackage.jsonD8.1:vscode(for some reason this one behaves strangely)D8.2: Other packagesD9: Auto-import imports from local packages that you depend on, using our preferred syntax (eg@cursorless/foo)D10: Auto-import doesn't import from local packages that you don't depend onD11: Auto-import doesn't import from anything other thanindex.tsin another package (eg no@cursorless/foo/bar)D11.1: When you depend on the packageD11.2: When you don't depend on the packageOther DX
D12: Find references across projects when no file from the referencing project is openD13: Rename across projects when no file from the referencing project is openD14: Jump to definition across projectsD15: It is easy to move a file from one package to anotherD16: It is easy to create a new packageD17: Breakpoints work in Cursorless extensionD18: Breakpoints work on Cursorless root websiteD19: Breakpoints work on Cursorless docs website