-
-
Notifications
You must be signed in to change notification settings - Fork 88
Fix test case recorder #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test case recorder #1341
Conversation
62dbc11
to
5d05b67
Compare
For some reason that I can't fathom, we're getting a CI failure on Windows because even though the test case recorder is correctly outputting a file with LF endings there, the expected content has CRLF endings. This is quite strange, because we're just reading a gold file that has LF endings. It's almost like GitHub action runner is turning on I could hack it by running |
packages/cursorless-vscode-e2e/src/suite/testCaseRecorder.test.ts
Outdated
Show resolved
Hide resolved
It's probably fairly likely this is enabled in the global config… maybe we should check its value before checkout? |
but how / why? I don't see anywhere that this is something GitHub does in their runners 🤔 |
Maybe we should try setting text=lf in .gitattributes 🤔 |
I'm hesitant to mess with that setting, as I don't fully understand it. It would be great to get this PR in, as the test case recorder is currently broken on main. Shall I file a follow-up to look into line endings? |
Yeah, that seems like a good idea: https://dev.to/deadlybyte/please-add-gitattributes-to-your-git-repository-1jld |
d9e23b3
to
b0727f2
Compare
Ok I filed #1348 to handle line endings properly |
a7aab72
to
890c41c
Compare
54b954c
to
51c2193
Compare
890c41c
to
7f09b35
Compare
b14ed17
to
8c63db1
Compare
8c63db1
to
e9f164d
Compare
Ok @AndreasArvidsson this one should be good to go. I added one more test that runs the test case recorder in the way we commonly do, where the user is prompted for a directory, rather than passing directory in via an argument to record test command. Prior to that, this PR actually had a bit of sleight of hand where I wasn't actually running the test case recorder in the usual way, and in fact it wouldn't have caught the bug that this PR fixes 😅. Added new ability along the way to fake user input in quick pick; was trivial using our |
The test case recorder broke in #1281 due to the fact we're now launching extension in subdirectory called
dist
rather than top-level repo. This PR fixes itChecklist