Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Allow disabling named param destructuring with --destructure-named-params (issue #396) #398

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

ochafik
Copy link
Contributor

@ochafik ochafik commented Dec 11, 2015

Right now one also needs to regenerate the runtime (see #397):
./tools/build_sdk --no-destructure-named-params

Hey @devoncarew, I don't know how the Atom plugin is built but if it's possible to run build_sdk.sh before running dartdevc.dart then this might be a workaround for that bug.

…rams (issue #396)

Right now one also needs to regenerate the runtime (see #397):
./tools/build_sdk --no-destructure-named-params
@devoncarew
Copy link
Contributor

We try and use the latest published version of dev_compiler, including the runtime that it comes with. We can pass an arg when we build the app (--no-destructure-named-params), but it would be great if we didn't also have to checkout the repo and re-build the runtime w/ this option. Is it necessary / useful for the built-in runtime to use the named param destructuring feature?

vsmenon added a commit that referenced this pull request Dec 11, 2015
Allow disabling named param destructuring with --destructure-named-params (issue #396)
@vsmenon vsmenon merged commit 9e37dc0 into master Dec 11, 2015
@vsmenon vsmenon deleted the destructuring-flag branch December 11, 2015 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants