This repository was archived by the owner on Jan 28, 2024. It is now read-only.
[dev] Removed the usage of --no-sound-null-safety #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably better to merge in master into this PR after merging #136 to master, and only update pubspec.yaml / readme / changelog. |
* Removed usage of --no-sound-null-safety flag * Update version, changelog * Use flag when running tests on travis
…no-sound-null-safety-flag
|
@dcharkes you can review this now. |
dcharkes
approved these changes
Jan 11, 2021
mannprerak2
added a commit
to mannprerak2/ffigen
that referenced
this pull request
Mar 1, 2021
* Removed the usage of --no-sound-null-safety, updated version, changelog * Add include path for systems with LLVM 11 (e.g. Debian 11) (dart-archive#125) * Removed usage of --no-sound-null-safety flag. (dart-archive#136) * Removed usage of --no-sound-null-safety flag * Update version, changelog * Use flag when running tests on travis Co-authored-by: J-P Nurmi <[email protected]>
dcharkes
pushed a commit
that referenced
this pull request
Mar 1, 2021
…) (#164) Co-authored-by: J-P Nurmi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --no-sound-null-safety flag was causing an issue when package was being run, since it is first precompiled. See comments on dart-lang/native#375.
This PR fixes that for the dart-dev branch, it follows the approach of the package:test => https://github.com/dart-lang/test/blob/master/pkgs/test/bin/test.dart.