Merge branch 'dart-dev' into 'master'. #154
Conversation
Co-authored-by: J-P Nurmi <[email protected]>
* Added support for structs by value, fixed tests and example * updated version, readme, changelog * Added more tests * Added struct return by value to native test * Fix struct by value in nested typedefs
* Removed the usage of --no-sound-null-safety, updated version, changelog * Add include path for systems with LLVM 11 (e.g. Debian 11) (dart-archive#125) * Removed usage of --no-sound-null-safety flag. (dart-archive#136) * Removed usage of --no-sound-null-safety flag * Update version, changelog * Use flag when running tests on travis Co-authored-by: J-P Nurmi <[email protected]>
* Use Opaque to represent empty structs, updated tests, changelog, version
* Updated code_generator_tests * Throw exception if formatting fails * minor change
We can mark ourselves as no longer experimental.
* Updated package:quiver version
mannprerak2
force-pushed
the
dart-dev
branch
from
0513d76 to
19aa2d7
Compare
|
I don't have a lot of context here, so hard to comment. The preferred solution is a set of small targeted PRs, each of which can then be squashed. |
|
We've been extending this package based on new We've made |
|
Could we bring the changes over in a set of feature-based PRs? |
|
We could, but this would be a recurring issue every stable release.
And then every stable release, we would have to redo all the PRs from the dev branch to the stable branch. Wouldn't it be cleaner to have just a merge from dev to stable every Dart stable release? |
|
@dcharkes Should I squash the last 2 commits into 1 commit? |
|
Alternative approach as suggested by @mit is to have the master branch track dart dev releases and do all the PRs there. And then when we make a stable release make the master branch track dart stable (or beta). As for getting this work on to the master branch, we could make individual PRs grouping commits on this branch.
|
|
After discussing with @natebosch, we came up with this: https://github.com/dart-lang/ffigen/wiki/Branches. |
|
Done in separate PRs. |
Closes dart-lang/native#385