Skip to content
This repository was archived by the owner on Jan 28, 2024. It is now read-only.

Support for generating Variadic functions #515

Merged
merged 11 commits into from
May 1, 2023

Conversation

mannprerak2
Copy link
Contributor

@mannprerak2 mannprerak2 commented Feb 12, 2023

Closes dart-lang/native#497

Just a draft. I've added a test but it currently skips formatting.

@dcharkes feel free to take a look and suggest changes, although we should probably wait for Dart 3 to merge this.

@dcharkes
Copy link
Contributor

Tracking bug for formatter:

Copy link
Contributor

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@dcharkes
Copy link
Contributor

dcharkes commented May 1, 2023

This work can be rebased on the master branch now that that's on 3.0

@mannprerak2 mannprerak2 force-pushed the variadic_functions branch from f6feddd to 7be9b2e Compare May 1, 2023 10:15
@mannprerak2 mannprerak2 marked this pull request as ready for review May 1, 2023 12:29
@mannprerak2 mannprerak2 requested a review from dcharkes May 1, 2023 12:30
Copy link
Contributor

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support variadic functions
2 participants