Skip to content

[Records] dart_style support #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
itsjustkevin opened this issue Aug 19, 2022 · 5 comments
Closed

[Records] dart_style support #1128

itsjustkevin opened this issue Aug 19, 2022 · 5 comments
Assignees
@munificent
Labels
language-change

Comments

@itsjustkevin
Copy link

No description provided.

@pq pq mentioned this issue Sep 7, 2022
Open
@jr1221
Copy link

jr1221 commented Dec 6, 2022

Is there any way to make the formatter selectively ignore lines with records usage instead of the whole file while this is still being worked on?

@munificent
Copy link
Member

No, sorry. The easiest workaround is to just not use the formatter until it has record support.

@jr1221
Copy link

jr1221 commented Dec 6, 2022

Ok, thank you!

@munificent munificent mentioned this issue Jan 6, 2023
Closed
@dcharkes dcharkes mentioned this issue Feb 13, 2023
Merged
@csells
Copy link

csells commented Feb 18, 2023

oh my goodness; using the Dart 3 alpha is super painful w/o dart format support. please type faster! : )

@munificent
Copy link
Member

This is now done and rolled into the bleeding edge Dart SDK.

copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 21, 2023
@dcharkes
[test/ffi] Format record types
a045aea 
Now that dart-lang/dart_style#1128 has been
addressed, format the files testing varargs.

And skips `printf` executable lookup on Android.

Closes: #52112
Change-Id: I31158ad7a5ddd8520bbee5d67e427ee4c1f3da9e
Cq-Include-Trybots: luci.dart.try:vm-ffi-android-debug-arm-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/296800
Reviewed-by: Martin Kustermann <[email protected]>
Commit-Queue: Daco Harkes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
language-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@munificent @csells @itsjustkevin @jr1221