This repository was archived by the owner on Nov 20, 2024. It is now read-only.
stop discarding futures #3455
Merged
stop discarding futures #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwilkerson
approved these changes
Jun 14, 2022
albertms10
reviewed
Jun 15, 2022
| @@ -20,10 +20,10 @@ import 'package:path/path.dart' as path; | |||
|
|
|||
| import 'rules/visit_registered_nodes.dart'; | |||
|
|
|||
| void main() { | |||
| Future<void> main() async { | |||
There was a problem hiding this comment.
Relaxing avoid_void_async to allow this idiom does sort of suggest this Future return type annotation is gratuitous. Interestingly, this is what the analyzer ADD_ASYNC quick-fix produces. Maybe we should consider updating it to not do this for main?
/cc @bwilkerson
As for a cleanup PR, @albertms10, sure thing.
Thanks for the feedback!
There was a problem hiding this comment.
I have no idea how common that idiom is, but if it's common enough then it would make sense to support it. Not sure who ought to be looped in to the conversation.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: dart-lang/sdk#58747.
/cc @bwilkerson