-
Notifications
You must be signed in to change notification settings - Fork 30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💎
764af55
to
6f818dd
Compare
lib/flutter.yaml
Outdated
@@ -0,0 +1,17 @@ | |||
# Lints recommended for Flutter apps and packages. | |||
|
|||
include: package:lints/recommend.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"recommended.yaml" now.
Can this be a relative path, so just "recommended.yaml"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to the new name.
It appears that a relative path works here, I was just following how "recommended.yaml" is importing core:
@pq Should we change that and this one to use the relative path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @bwilkerson who knows more about nuances of includes
... Brian: any reason not to use a relative path import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see an argument for using the package:...
reference style being that people cribbing off this file would be able to use if for their own analysis options files (a relative reference wouldn't work for them).
6f818dd
to
400c60b
Compare
Superseded by flutter/packages#343. |
Fixes dart-lang/sdk#58349.
/cc @pq @mit-mit @Hixie