Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

Add lints for Flutter apps and packages #9

Closed
wants to merge 3 commits into from

Conversation

goderbauer
Copy link
Contributor

@goderbauer goderbauer mentioned this pull request Apr 27, 2021
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

lib/flutter.yaml Outdated
@@ -0,0 +1,17 @@
# Lints recommended for Flutter apps and packages.

include: package:lints/recommend.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"recommended.yaml" now.

Can this be a relative path, so just "recommended.yaml"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to the new name.

It appears that a relative path works here, I was just following how "recommended.yaml" is importing core:

https://github.com/dart-lang/lints/blob/1f80da49abf8b4ea15461e42ebb09eb51917b49d/lib/recommended.yaml#L1

@pq Should we change that and this one to use the relative path?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bwilkerson who knows more about nuances of includes... Brian: any reason not to use a relative path import?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see an argument for using the package:... reference style being that people cribbing off this file would be able to use if for their own analysis options files (a relative reference wouldn't work for them).

@goderbauer
Copy link
Contributor Author

Superseded by flutter/packages#343.

@goderbauer goderbauer closed this May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Lints to be considered for score.yaml or recommend.yaml from Flutter
4 participants