Skip to content

Add flutter_lints package #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 5, 2021
Merged

Add flutter_lints package #343

merged 8 commits into from
May 5, 2021

Conversation

goderbauer
Copy link
Member

@google-cla google-cla bot added the cla: yes label May 5, 2021
@goderbauer
Copy link
Member Author

/cc @pq @devoncarew @mit-mit @csells

@@ -0,0 +1,17 @@
# Recomended lints for Flutter apps, packages, and plugins.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> Recommended

@@ -0,0 +1,13 @@
name: flutter_lints
description: Recommended lints for Flutter apps, packages, and plugins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End with a period?

=>

Recommended lints for Flutter apps, packages, and plugins.

description: Recommended lints for Flutter apps, packages, and plugins
version: 0.1.0
homepage: https://github.com/flutter/packages/tree/master/packages/flutter_lints
publish_to: none
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, yes. However, while I pull in the "lints" dependency directly from github below, there's a lint telling me that I need this. 😝

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha!

@goderbauer goderbauer requested a review from devoncarew May 5, 2021 20:07
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎


environment:
sdk: '>=2.12.0 <3.0.0'

dependencies:
lints: # TODO(goderbauer): depend on released version before releasing the package
git: https://github.com/dart-lang/lints.git
lints: ^1.0.0-dev.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@goderbauer goderbauer merged commit b17875f into flutter:master May 5, 2021
@goderbauer goderbauer deleted the flutter_lints branch May 5, 2021 23:54
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
Add title to CupertinoPageRoute
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
* Transform clip path when applied to a group

Fix #136, #343, #566

* Golden test added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants