-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add flutter_lints package #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -0,0 +1,17 @@ | |||
# Recomended lints for Flutter apps, packages, and plugins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=> Recommended
packages/flutter_lints/pubspec.yaml
Outdated
@@ -0,0 +1,13 @@ | |||
name: flutter_lints | |||
description: Recommended lints for Flutter apps, packages, and plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End with a period?
=>
Recommended lints for Flutter apps, packages, and plugins.
packages/flutter_lints/pubspec.yaml
Outdated
description: Recommended lints for Flutter apps, packages, and plugins | ||
version: 0.1.0 | ||
homepage: https://github.com/flutter/packages/tree/master/packages/flutter_lints | ||
publish_to: none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately, yes. However, while I pull in the "lints" dependency directly from github below, there's a lint telling me that I need this. 😝
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💎
|
||
environment: | ||
sdk: '>=2.12.0 <3.0.0' | ||
|
||
dependencies: | ||
lints: # TODO(goderbauer): depend on released version before releasing the package | ||
git: https://github.com/dart-lang/lints.git | ||
lints: ^1.0.0-dev.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Add title to CupertinoPageRoute
flutter/flutter#78432