Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

optimize usage of observers in MDV and PolymerExpressions #30

Closed

Description

@DartBot

<img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="96" height="96"hspace="10"> Issue by jmesserly
Originally opened as dart-lang/sdk#12392


We often create observers even for silly things, e.g. observing the "value" property of a CompoundBindings. FancySyntax has even more observers. We can skip at least the PathObserver if the thing we're observing just has a ".value"

Activity

  1. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


    Still an issue?


    Removed Library-FancySyntax label.
    Added Library-PolymerExpressions label.
    Changed the title to: "optimize usage of observers in MDV and PolymerExpressions".

  2. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/522948?v=3" align="left" width="48" height="48"hspace="10"> Comment by justinfagnani


    Yes

  3. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


    Added this to the M8 milestone.

  4. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


    Removed this from the M8 milestone.
    Added this to the Later milestone.

  5. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly


    this is partially fixed. NodeBinding is smart about not creating yet-another-pathobserer. TemplateIterator is smarter too.

    Still work to be done:

    • PolymerExpressions is creating way too many Scopes.
    • we still create PathObservers for empty paths.
    • need another special case for "value" in PathObserver. would be nice to avoid dart:mirrors.
    • also need a special case for a single-segment path.

    Removed Library-MDV label.

  6. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


    Removed this from the Later milestone.
    Added this to the M9 milestone.

  7. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/8616782?v=3" align="left" width="48" height="48"hspace="10"> Comment by clayberg


    Removed this from the M9 milestone.
    Added this to the 1.1 milestone.

  8. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


    Removed this from the 1.1 milestone.
    Added this to the 1.2 milestone.

  9. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/3276024?v=3" align="left" width="48" height="48"hspace="10"> Comment by anders-sandholm


    Removed Library-Observe label.
    Added Pkg-Observe label.

  10. DartBot commented on Jun 5, 2015

    @DartBot
    Author

    <img src="https://avatars.githubusercontent.com/u/1081711?v=3" align="left" width="48" height="48"hspace="10"> Comment by jmesserly


    Rafael has been slowly fixing this on the observe-js/TemplateBinding/polymer-expressions side of the world, and we've been porting those changes. I'd say it's good enough at this point.


    Added Fixed label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions