Skip to content

co19_2 tests failures #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sgrekhov opened this issue Jul 26, 2022 · 2 comments
Closed

co19_2 tests failures #1376

sgrekhov opened this issue Jul 26, 2022 · 2 comments
Assignees
@sgrekhov

Comments

@sgrekhov
Copy link
Contributor

Triage failures of co19_2 tests

https://ci.chromium.org/p/dart/builders/ci.sandbox/dart2js-strong-linux-x64-chrome

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8807646386557525441/+/u/test_results/ignored_flaky_test_failure_logs
@sgrekhov sgrekhov self-assigned this Jul 26, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 26, 2022
@sgrekhov
Fixes dart-lang#1376. Broken co19_2 test fixed
df986d3
@sgrekhov
Copy link
Contributor Author

All of the failed flaky tests works well for me locally on the edge version of SDK on dart2js-linux-chrome configuration.

@eernstg
Copy link
Member

eernstg commented Jul 26, 2022

Thanks! I think we can close this, and return to the topic if further concerns are raised.

eernstg pushed a commit that referenced this issue Jul 26, 2022
@sgrekhov
Fixes #1376. Broken co19_2 test fixed (#1377)
439c808 
Authored by @sgrekhov.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 30, 2022
@sgrekhov
[co19] Roll co19_2 to bb3d5399f6335011231cd57b127748bee81f2b40
cb45aa8 
2022-09-30 [email protected] Fixes dart-lang/co19#1478. Failures of the new co19_2 roll fixed. (dart-lang/co19#1480)
2022-09-28 [email protected] dart-lang/co19#195. RawDatagramSocket tests fixed (dart-lang/co19#1465)
2022-08-31 [email protected] dart-lang/co19#1405. Don't use deprecated API in co19_2 tests (dart-lang/co19#1409)
2022-08-31 [email protected] dart-lang/co19#1405. co19_2. BytesBuilder tests moved from dart:io to dart:typed_data (dart-lang/co19#1411)
2022-08-23 [email protected] dart-lang/co19#1394. Add missing compile-error (dart-lang/co19#1397)
2022-08-03 [email protected] dart-lang/co19#1129. In case of DIRECT connection don't expect any proxy routine called (dart-lang/co19#1385)
2022-07-29 [email protected] dart-lang/co19#673. IFrame tests that don't actually test IFrame removed (dart-lang/co19#1381)
2022-07-27 [email protected] Fixes dart-lang/co19#1376. Broken co19_2 test fixed (dart-lang/co19#1377)
2022-07-12 [email protected] Fixes dart-lang/co19#1356. Add analyzer errors on references to not included library parts (dart-lang/co19#1359)
2022-07-05 [email protected] Fixes dart-lang/co19#1309. Update error expectations according to the current behavior (dart-lang/co19#1351)
2022-07-04 [email protected] Fixes dart-lang/co19#1343. Use correct 'part' and 'part of' directives (dart-lang/co19#1350)
2022-07-01 [email protected] Fixes dart-lang/co19#1313. Pre-nnbd tests for focus_A01_t01 and blur_A01_t01 updated to their version in master (dart-lang/co19#1345)

Change-Id: Iec8355f25b2c87b3dd83d84d2bab95812bbd0686
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262204
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
eernstg pushed a commit that referenced this issue Oct 11, 2022
@sgrekhov
#1430. For HashSet don't run tests that checks iteration order (#1475)
65711c0 
Authored by @sgrekhov.

Fixes #1376. Broken co19_2 test fixed.
Fixes #1430. For HashSet don't run tests that checks iteration order.
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg