Skip to content

Failures on [parser] Better recovery for extra stuff in enum #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jensjoha opened this issue Feb 25, 2022 · 0 comments
Closed

Failures on [parser] Better recovery for extra stuff in enum #1309

jensjoha opened this issue Feb 25, 2022 · 0 comments
Assignees
@sgrekhov

Comments

@jensjoha
Copy link

There are new test failures on [parser] Better recovery for extra stuff in enum (landed as 514f678199fa55009b6e126977c1e294e67eb423).

The tests

co19/Language/Reference/Lexical_Rules/Reserved_Words/class_t10 MissingCompileTimeError (expected Pass)
co19/Language/Reference/Lexical_Rules/Reserved_Words/class_t11 MissingCompileTimeError (expected Pass)
co19/Language/Reference/Lexical_Rules/Reserved_Words/enum_t10 MissingCompileTimeError (expected Pass)
co19/Language/Reference/Lexical_Rules/Reserved_Words/enum_t11 MissingCompileTimeError (expected Pass)
co19_2/Language/Reference/Lexical_Rules/Reserved_Words/class_t10 MissingCompileTimeError (expected Pass)
co19_2/Language/Reference/Lexical_Rules/Reserved_Words/class_t11 MissingCompileTimeError (expected Pass)
co19_2/Language/Reference/Lexical_Rules/Reserved_Words/enum_t10 MissingCompileTimeError (expected Pass)
co19_2/Language/Reference/Lexical_Rules/Reserved_Words/enum_t11 MissingCompileTimeError (expected Pass)

are failing on configurations

analyzer-asserts-linux
analyzer-asserts-strong-linux
analyzer-asserts-weak-linux
cfe-linux
cfe-strong-linux
cfe-weak-linux

and needs updating.
@sgrekhov sgrekhov self-assigned this Jul 5, 2022
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 5, 2022
Fixes dart-lang#1309. Update error expectations according to the curr…
35c20b7 
…ent behavior
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 5, 2022
Fixes dart-lang#1309. Update error expectations according to the curr…
ee6ac86 
…ent behavior
@eernstg eernstg closed this as completed in 2d8fe85 Jul 5, 2022
eernstg pushed a commit that referenced this issue Jul 5, 2022
@sgrekhov
Fixes #1309. Update error expectations according to the current behav…
5929a68 
…ior (#1351)

Co-authored-by: sgrekhov <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 14, 2022
@eernstg
[co19] Roll co19 to 5e94d0db25a8d8dfb6b1320bdb342e2935faf1d0
fd01012 
2022-07-13 [email protected] Add initial specparser workflow (dart-lang/co19#1364)
2022-07-07 [email protected] Fixes dart-lang/co19#1355. Expect that `Process.killPid` returns `false` only if process is already dead (dart-lang/co19#1357)
2022-07-06 [email protected] Fixes dart-lang/co19#1328. Fix error expectation places for CFE (dart-lang/co19#1353)
2022-07-05 [email protected] Fixes dart-lang/co19#1309. Update error expectations according to the current behavior (dart-lang/co19#1352)
2022-07-05 [email protected] Fix finalizer tests (dart-lang/co19#1338)
2022-07-04 [email protected] Fixes dart-lang/co19#1343. Use correct 'part' and 'part of' directives (dart-lang/co19#1349)
2022-07-04 [email protected] Fix typos (dart-lang/co19#1341)
2022-07-04 [email protected] Fixes dart-lang/co19#1340. Update expected error locations for CFE (dart-lang/co19#1348)
2022-07-04 [email protected] Fixes dart-lang/co19#1344. Wait for entryPoint is invoked before doing the test (dart-lang/co19#1346)
2022-07-01 [email protected] Fixes dart-lang/co19#1342. Expect STATIC_WARNING.INVALID_NULL_AWARE_OPERATOR for C?.foo (dart-lang/co19#1347)

Change-Id: I1d5b116297f4b94930988914de4c0e03b68b2b8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251463
Reviewed-by: Alexander Thomas <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Sep 30, 2022
@sgrekhov
[co19] Roll co19_2 to bb3d5399f6335011231cd57b127748bee81f2b40
cb45aa8 
2022-09-30 [email protected] Fixes dart-lang/co19#1478. Failures of the new co19_2 roll fixed. (dart-lang/co19#1480)
2022-09-28 [email protected] dart-lang/co19#195. RawDatagramSocket tests fixed (dart-lang/co19#1465)
2022-08-31 [email protected] dart-lang/co19#1405. Don't use deprecated API in co19_2 tests (dart-lang/co19#1409)
2022-08-31 [email protected] dart-lang/co19#1405. co19_2. BytesBuilder tests moved from dart:io to dart:typed_data (dart-lang/co19#1411)
2022-08-23 [email protected] dart-lang/co19#1394. Add missing compile-error (dart-lang/co19#1397)
2022-08-03 [email protected] dart-lang/co19#1129. In case of DIRECT connection don't expect any proxy routine called (dart-lang/co19#1385)
2022-07-29 [email protected] dart-lang/co19#673. IFrame tests that don't actually test IFrame removed (dart-lang/co19#1381)
2022-07-27 [email protected] Fixes dart-lang/co19#1376. Broken co19_2 test fixed (dart-lang/co19#1377)
2022-07-12 [email protected] Fixes dart-lang/co19#1356. Add analyzer errors on references to not included library parts (dart-lang/co19#1359)
2022-07-05 [email protected] Fixes dart-lang/co19#1309. Update error expectations according to the current behavior (dart-lang/co19#1351)
2022-07-04 [email protected] Fixes dart-lang/co19#1343. Use correct 'part' and 'part of' directives (dart-lang/co19#1350)
2022-07-01 [email protected] Fixes dart-lang/co19#1313. Pre-nnbd tests for focus_A01_t01 and blur_A01_t01 updated to their version in master (dart-lang/co19#1345)

Change-Id: Iec8355f25b2c87b3dd83d84d2bab95812bbd0686
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262204
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @jensjoha