Skip to content

Tests need expectation updates #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnniwinther opened this issue May 17, 2022 · 0 comments
Closed

Tests need expectation updates #1340

johnniwinther opened this issue May 17, 2022 · 0 comments
Assignees
@sgrekhov

Comments

@johnniwinther
Copy link
Member

There are new test failures on [cfe] Remove FunctionType.typedefType.

The tests

co19/Language/Generics/Superbounded_types/class_A01_t02 MissingCompileTimeError (expected Pass)
co19/Language/Generics/Superbounded_types/class_A01_t03 MissingCompileTimeError (expected Pass)
co19/Language/Generics/Superbounded_types/class_A01_t05 MissingCompileTimeError (expected Pass)
co19/Language/Generics/Superbounded_types/class_A04_t01 MissingCompileTimeError (expected Pass)
co19/Language/Generics/Superbounded_types/class_A04_t02 MissingCompileTimeError (expected Pass)
co19/Language/Generics/Superbounded_types/class_A04_t03 MissingCompileTimeError (expected Pass)
co19/Language/Generics/Superbounded_types/function_A01_t01 MissingCompileTimeError (expected Pass)
co19/Language/Generics/class_A01_t02 MissingCompileTimeError (expected Pass)
co19/Language/Generics/class_A02_t01 MissingCompileTimeError (expected Pass)
co19/Language/Generics/parameter_A01_t02 MissingCompileTimeError (expected Pass)
co19/Language/Generics/parameter_A01_t04 MissingCompileTimeError (expected Pass)
co19/Language/Generics/typedef_A08_t02 MissingCompileTimeError (expected Pass)
co19/Language/Generics/typedef_A08_t03 MissingCompileTimeError (expected Pass)
co19/Language/Generics/typedef_A08_t04 MissingCompileTimeError (expected Pass)
co19/Language/Types/Static_Types/malformed_type_t01 MissingCompileTimeError (expected Pass)

are failing on configurations

cfe-strong-linux
cfe-weak-linux

All tests need to be updated to match new expectations.
@sgrekhov sgrekhov self-assigned this Jul 4, 2022
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 4, 2022
Fixes dart-lang#1340. Update expected error locations for CFE
7a9da84
@eernstg eernstg closed this as completed in d17cc6d Jul 4, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 14, 2022
@eernstg
[co19] Roll co19 to 5e94d0db25a8d8dfb6b1320bdb342e2935faf1d0
fd01012 
2022-07-13 [email protected] Add initial specparser workflow (dart-lang/co19#1364)
2022-07-07 [email protected] Fixes dart-lang/co19#1355. Expect that `Process.killPid` returns `false` only if process is already dead (dart-lang/co19#1357)
2022-07-06 [email protected] Fixes dart-lang/co19#1328. Fix error expectation places for CFE (dart-lang/co19#1353)
2022-07-05 [email protected] Fixes dart-lang/co19#1309. Update error expectations according to the current behavior (dart-lang/co19#1352)
2022-07-05 [email protected] Fix finalizer tests (dart-lang/co19#1338)
2022-07-04 [email protected] Fixes dart-lang/co19#1343. Use correct 'part' and 'part of' directives (dart-lang/co19#1349)
2022-07-04 [email protected] Fix typos (dart-lang/co19#1341)
2022-07-04 [email protected] Fixes dart-lang/co19#1340. Update expected error locations for CFE (dart-lang/co19#1348)
2022-07-04 [email protected] Fixes dart-lang/co19#1344. Wait for entryPoint is invoked before doing the test (dart-lang/co19#1346)
2022-07-01 [email protected] Fixes dart-lang/co19#1342. Expect STATIC_WARNING.INVALID_NULL_AWARE_OPERATOR for C?.foo (dart-lang/co19#1347)

Change-Id: I1d5b116297f4b94930988914de4c0e03b68b2b8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251463
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @johnniwinther