Fix finalizer tests #1338
Merged
Fix finalizer tests #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmarkov
requested changes
May 6, 2022
LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/FinalizationRegistry/ffi/Finalizer/Finalizer_A01_t01.dart
Outdated
Show resolved
Hide resolved
| await attachToFinalizer(); | ||
| // Previous triggerGc move some objects to old space. Do multiple GCs to | ||
| // force all objects to old space. | ||
| await triggerGcWithDelay(repeat: 3); |
There was a problem hiding this comment.
This comment and additional GCs look very implementation-specific. My understanding is that these tests should only rely on the specification.
There was a problem hiding this comment.
Finalizer specification says that objects may be collected. So then we cannot have a single test that checks that an object is collected.
@lrhn please advise.
LanguageFeatures/FinalizationRegistry/ffi/Finalizer/attach_A02_t01.dart
Outdated
Show resolved
Hide resolved
alexmarkov
approved these changes
May 6, 2022
|
@dcharkes what is the status of this PR? It is approved but there are still some open questions. If you want I can go on work on this PR |
|
I think we can land it as is. It does not really make sense to only conform to specification, because that means we cannot test any finalizers (finalizers may run, objects may be GCed). Thanks for pinging the PR @sgrekhov. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jul 14, 2022
2022-07-13 [email protected] Add initial specparser workflow (dart-lang/co19#1364) 2022-07-07 [email protected] Fixes dart-lang/co19#1355. Expect that `Process.killPid` returns `false` only if process is already dead (dart-lang/co19#1357) 2022-07-06 [email protected] Fixes dart-lang/co19#1328. Fix error expectation places for CFE (dart-lang/co19#1353) 2022-07-05 [email protected] Fixes dart-lang/co19#1309. Update error expectations according to the current behavior (dart-lang/co19#1352) 2022-07-05 [email protected] Fix finalizer tests (dart-lang/co19#1338) 2022-07-04 [email protected] Fixes dart-lang/co19#1343. Use correct 'part' and 'part of' directives (dart-lang/co19#1349) 2022-07-04 [email protected] Fix typos (dart-lang/co19#1341) 2022-07-04 [email protected] Fixes dart-lang/co19#1340. Update expected error locations for CFE (dart-lang/co19#1348) 2022-07-04 [email protected] Fixes dart-lang/co19#1344. Wait for entryPoint is invoked before doing the test (dart-lang/co19#1346) 2022-07-01 [email protected] Fixes dart-lang/co19#1342. Expect STATIC_WARNING.INVALID_NULL_AWARE_OPERATOR for C?.foo (dart-lang/co19#1347) Change-Id: I1d5b116297f4b94930988914de4c0e03b68b2b8d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251463 Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1337