Skip to content

co19/LibTest/isolate/Isolate/kill_A01_t04 is racy #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkustermann opened this issue Jun 17, 2022 · 0 comments
Closed

co19/LibTest/isolate/Isolate/kill_A01_t04 is racy #1344

mkustermann opened this issue Jun 17, 2022 · 0 comments
Assignees

Comments

@mkustermann
Copy link
Member

Fundamentally the same issue as described in #1095.

After await Isolate.spawn() has returned the isolate was created but the entrypoint hasn't necessarily run yet, so an isolate.kill() may kill it before the entrypoint is run.

I'd suggest making the isolate communicate back to the main isolate that it started running the entrypoint (something similar to eccdd5c)

@sgrekhov sgrekhov self-assigned this Jul 1, 2022
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 1, 2022
@eernstg eernstg closed this as completed in 54501f2 Jul 4, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 14, 2022
2022-07-13 [email protected] Add initial specparser workflow (dart-lang/co19#1364)
2022-07-07 [email protected] Fixes dart-lang/co19#1355. Expect that `Process.killPid` returns `false` only if process is already dead (dart-lang/co19#1357)
2022-07-06 [email protected] Fixes dart-lang/co19#1328. Fix error expectation places for CFE (dart-lang/co19#1353)
2022-07-05 [email protected] Fixes dart-lang/co19#1309. Update error expectations according to the current behavior (dart-lang/co19#1352)
2022-07-05 [email protected] Fix finalizer tests (dart-lang/co19#1338)
2022-07-04 [email protected] Fixes dart-lang/co19#1343. Use correct 'part' and 'part of' directives (dart-lang/co19#1349)
2022-07-04 [email protected] Fix typos (dart-lang/co19#1341)
2022-07-04 [email protected] Fixes dart-lang/co19#1340. Update expected error locations for CFE (dart-lang/co19#1348)
2022-07-04 [email protected] Fixes dart-lang/co19#1344. Wait for entryPoint is invoked before doing the test (dart-lang/co19#1346)
2022-07-01 [email protected] Fixes dart-lang/co19#1342. Expect STATIC_WARNING.INVALID_NULL_AWARE_OPERATOR for C?.foo (dart-lang/co19#1347)

Change-Id: I1d5b116297f4b94930988914de4c0e03b68b2b8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251463
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants