Skip to content

Views tests should use the 'views' experimental flag #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnniwinther opened this issue Nov 9, 2022 · 2 comments
Closed

Views tests should use the 'views' experimental flag #1539

johnniwinther opened this issue Nov 9, 2022 · 2 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@johnniwinther
Copy link
Member

The views tests, for instance co19/LanguageFeatures/Views/syntax_A02_t04.dart, use the extension-types flag:

// SharedOptions=--enable-experiment=extension-types

instead of the correct views flag:

// SharedOptions=--enable-experiment=views
@eernstg
Copy link
Member

eernstg commented Nov 9, 2022

The mechanism was just renamed to 'inline class'. Perhaps it would be helpful to rename the flag, too?

@johnniwinther
Copy link
Member Author

Ok. I (try to) rename the flag (haven't tried that before) and give a heads up when that change has landed.

@sgrekhov sgrekhov self-assigned this Nov 10, 2022
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Nov 14, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 15, 2022
@sgrekhov
Fixes dart-lang#1539. Rename "views" experimental flag to "inline-class"
bdf1988
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 19, 2022
@sgrekhov
dart-lang#1539. Inline classes tests updated according to the new syntax
db1bdb3
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 19, 2022
@sgrekhov
dart-lang#1539. Implementing review suggestions
3e0f98e
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 21, 2022
@sgrekhov @athomas
[co19] Roll co19 to f4bd100ed6fe9a1f9a98d6e4163d742824fbf21c
0c87c84 
2022-12-20 [email protected] dart-lang/co19#1401. [Patterns] Object pattern tests (dart-lang/co19#1602)
2022-12-20 [email protected] Fixes dart-lang/co19#1539. Rename "views" experimental flag to "inline-class" (dart-lang/co19#1596)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.1.0 to 3.2.0 (dart-lang/co19#1607)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.8.0 to 3.9.0 (dart-lang/co19#1608)
2022-12-19 [email protected] dart-lang/co19#1604. Update errors expectations for metadata parsing (dart-lang/co19#1605)
2022-12-19 [email protected] Fixes dart-lang/co19#1601. Expect compile-time error for elementAt() invocation on not a constant (dart-lang/co19#1603)
2022-12-16 [email protected] dart-lang/co19#1599. Expect TypeError in place of NullThrownError in co19 tests (dart-lang/co19#1600)

Change-Id: I490806d7116f66dc294921561bdec350039e44f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276901
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgrekhov @eernstg @johnniwinther