Skip to content

Failures on [parser] Breaking change for metadata parsing #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jensjoha opened this issue Dec 19, 2022 · 0 comments
Closed

Failures on [parser] Breaking change for metadata parsing #1604

jensjoha opened this issue Dec 19, 2022 · 0 comments
Assignees
@sgrekhov

Comments

@jensjoha
Copy link

There are new test failures on [parser] Breaking change for metadata parsing.

The tests

co19/Language/Metadata/syntax_t07 MissingCompileTimeError (expected Pass)
co19_2/Language/Metadata/syntax_t07 MissingCompileTimeError (expected Pass)

have changed expectations.
@sgrekhov sgrekhov self-assigned this Dec 19, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 19, 2022
@sgrekhov
dart-lang#1604. Update errors expectations for metadata parsing
74f5b43
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 19, 2022
@sgrekhov
dart-lang#1604. Update errors expectations for metadata parsing in co…
5ef5fd3 
…19_2
eernstg pushed a commit that referenced this issue Dec 19, 2022
@sgrekhov
#1604. Update errors expectations for metadata parsing in co19_2 (#1606)
8ba5eb6
eernstg pushed a commit that referenced this issue Dec 19, 2022
@sgrekhov
#1604. Update errors expectations for metadata parsing (#1605)
f6da533
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 21, 2022
@sgrekhov
[co19] Roll co19_2 to 8ba5eb65399044d20370c8cfd115e1f6bc51acb1
036faf5 
2022-12-19 [email protected] dart-lang/co19#1604. Update errors expectations for metadata parsing in co19_2 (dart-lang/co19#1606)

Change-Id: I4bbf241dad4336bbc285e6dc97d0a82335b79341
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276902
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 21, 2022
@sgrekhov @athomas
[co19] Roll co19 to f4bd100ed6fe9a1f9a98d6e4163d742824fbf21c
0c87c84 
2022-12-20 [email protected] dart-lang/co19#1401. [Patterns] Object pattern tests (dart-lang/co19#1602)
2022-12-20 [email protected] Fixes dart-lang/co19#1539. Rename "views" experimental flag to "inline-class" (dart-lang/co19#1596)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.1.0 to 3.2.0 (dart-lang/co19#1607)
2022-12-20 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.8.0 to 3.9.0 (dart-lang/co19#1608)
2022-12-19 [email protected] dart-lang/co19#1604. Update errors expectations for metadata parsing (dart-lang/co19#1605)
2022-12-19 [email protected] Fixes dart-lang/co19#1601. Expect compile-time error for elementAt() invocation on not a constant (dart-lang/co19#1603)
2022-12-16 [email protected] dart-lang/co19#1599. Expect TypeError in place of NullThrownError in co19 tests (dart-lang/co19#1600)

Change-Id: I490806d7116f66dc294921561bdec350039e44f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276901
Reviewed-by: Alexander Thomas <[email protected]>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @jensjoha