Skip to content

co19_2/LibTest/html/Element/isContentEditable_A01_t01 RuntimeError (expected Pass) #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rakudrama opened this issue Aug 14, 2020 · 2 comments
Closed

co19_2/LibTest/html/Element/isContentEditable_A01_t01 RuntimeError (expected Pass) #959

rakudrama opened this issue Aug 14, 2020 · 2 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@rakudrama
Copy link
Member

This test seems flaky.
@athomas Did something change with the test infrastructure?

The tests

co19_2/LibTest/html/Element/isContentEditable_A01_t01 RuntimeError (expected Pass)

are failing on configurations

dart2js-mac-safari
@athomas athomas transferred this issue from dart-lang/sdk Nov 5, 2020
@sgrekhov
Copy link
Contributor

@rakudrama how exactly this test fails on safary? Do you have failure logs?

@athomas
Copy link
Member

athomas commented Jan 5, 2021

https://dart-ci.appspot.com/log/any/dart2js-mac-safari/11891/co19_2/LibTest/html/Element/isContentEditable_A01_t01

sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 12, 2022
Fixes dart-lang#959. Fix flaky test. Enable user-select for Safari
94c934e
sgrekhov pushed a commit to sgrekhov/co19 that referenced this issue Jul 12, 2022
Fixes dart-lang#959. Fix flaky test. Enable user-select for Safari
f236af2
@sgrekhov sgrekhov self-assigned this Jul 12, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Jul 14, 2022
@sgrekhov
Fixes dart-lang#959. Fix flaky test. Enable user-select for Safari
3638790
@sgrekhov sgrekhov added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Aug 17, 2022
@sgrekhov sgrekhov added bad-test Report tests in need of updates. When closed, the tests should be considered good and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Nov 14, 2022
athomas pushed a commit that referenced this issue Dec 6, 2022
@sgrekhov
Fixes #959. Fix flaky test. Enable user-select for Safari (#1362)
07bf93a
@sgrekhov sgrekhov closed this as completed Dec 6, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 9, 2022
@sgrekhov
[co19] Roll co19_2 to 56f45529ff2818e8549d6e092fc478e73d68fcc0
98eedc6 
2022-12-09 [email protected] dart-lang/co19#1575. Remove unused code (dart-lang/co19#1579)
2022-12-08 [email protected] dart-lang/co19#1575. Update test expectations for analyzer (dart-lang/co19#1577)
2022-12-06 [email protected] Fixes dart-lang/co19#959. Fix flaky test. Enable user-select for Safari (dart-lang/co19#1362)

Change-Id: Ic09ebc4ba8563739bc2d1b6d95ad789019a43272
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274385
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rakudrama @sgrekhov @athomas