Skip to content

_FROM_DEFERRED_LIBRARY location #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scheglov opened this issue Dec 7, 2022 · 0 comments
Closed

_FROM_DEFERRED_LIBRARY location #1575

scheglov opened this issue Dec 7, 2022 · 0 comments
Assignees
@sgrekhov
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@scheglov
Copy link

scheglov commented Dec 7, 2022

With https://dart-review.googlesource.com/c/sdk/+/274141 we changed the location on which XYZ_FROM_DEFERRED_LIBRARY is reported. By doing this I broke following tests:

co19/Language/Expressions/Constants/static_constant_t06
co19/Language/Expressions/Constants/static_constant_t07
co19_2/Language/Expressions/Constants/static_constant_t06
co19_2/Language/Expressions/Constants/static_constant_t07
@sgrekhov sgrekhov self-assigned this Dec 8, 2022
@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Dec 8, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 8, 2022
@sgrekhov
dart-lang#1575. Update test expectations for analyzer
53845ef
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 8, 2022
@sgrekhov
dart-lang#1575. Update test expectations for analyzer
b5dfa30
eernstg pushed a commit that referenced this issue Dec 8, 2022
@sgrekhov
#1575. Update test expectations for analyzer (#1576)
258f4ed 
Authored by @sgrekhov.
eernstg pushed a commit that referenced this issue Dec 8, 2022
@sgrekhov
#1575. Update test expectations for analyzer (#1577)
a9f77e4 
Authored by @sgrekhov.
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 9, 2022
@sgrekhov @athomas
[co19] Roll co19 to 1caf238b37bb19081029a6580f31a728b1359dc0
cec026d 
2022-12-09 [email protected] dart-lang/co19#1401. [Patterns] List's rest pattern tests (dart-lang/co19#1578)
2022-12-08 [email protected] dart-lang/co19#1575. Update test expectations for analyzer (dart-lang/co19#1576)
2022-12-07 [email protected] dart-lang/co19#1401. [Patterns] Map patterns tests updated. Check primitive == for keys (dart-lang/co19#1574)
2022-12-07 [email protected] dart-lang/co19#1401. [Patterns] Logical and relational patterns tests refactored (dart-lang/co19#1573)
2022-12-06 [email protected] dart-lang/co19#1401. [Patterns] Map pattern tests (dart-lang/co19#1572)
2022-12-02 [email protected] Fixes dart-lang/co19#1553. Description wording fixed (dart-lang/co19#1569)
2022-12-02 [email protected] Fixes dart-lang/co19#1568. Exclude VM-specific test form web-platforms (dart-lang/co19#1570)

Change-Id: I69e3d49ac0b244ed12c266bd00a1c3ec9f8e1b45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274660
Reviewed-by: Alexander Thomas <[email protected]>
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Dec 9, 2022
@sgrekhov
dart-lang#1575. Remove unused code
cdff0d4
athomas pushed a commit that referenced this issue Dec 9, 2022
@sgrekhov
#1575. Remove unused code (#1579)
56f4552
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 9, 2022
@sgrekhov
[co19] Roll co19_2 to 56f45529ff2818e8549d6e092fc478e73d68fcc0
98eedc6 
2022-12-09 [email protected] dart-lang/co19#1575. Remove unused code (dart-lang/co19#1579)
2022-12-08 [email protected] dart-lang/co19#1575. Update test expectations for analyzer (dart-lang/co19#1577)
2022-12-06 [email protected] Fixes dart-lang/co19#959. Fix flaky test. Enable user-select for Safari (dart-lang/co19#1362)

Change-Id: Ic09ebc4ba8563739bc2d1b6d95ad789019a43272
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274385
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@athomas athomas mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @sgrekhov