Skip to content

#1575. Update test expectations for analyzer #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Dec 8, 2022

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't know why the analyzer and CFE treat the list as a whole differently, but it seems OK to simply expect the behavior that the tools have chosen.

@eernstg eernstg merged commit 258f4ed into dart-lang:master Dec 8, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 9, 2022
2022-12-09 [email protected] dart-lang/co19#1401. [Patterns] List's rest pattern tests (dart-lang/co19#1578)
2022-12-08 [email protected] dart-lang/co19#1575. Update test expectations for analyzer (dart-lang/co19#1576)
2022-12-07 [email protected] dart-lang/co19#1401. [Patterns] Map patterns tests updated. Check primitive == for keys (dart-lang/co19#1574)
2022-12-07 [email protected] dart-lang/co19#1401. [Patterns] Logical and relational patterns tests refactored (dart-lang/co19#1573)
2022-12-06 [email protected] dart-lang/co19#1401. [Patterns] Map pattern tests (dart-lang/co19#1572)
2022-12-02 [email protected] Fixes dart-lang/co19#1553. Description wording fixed (dart-lang/co19#1569)
2022-12-02 [email protected] Fixes dart-lang/co19#1568. Exclude VM-specific test form web-platforms (dart-lang/co19#1570)

Change-Id: I69e3d49ac0b244ed12c266bd00a1c3ec9f8e1b45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274660
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1575 branch December 26, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants