#673. IFrame tests that don't actually test IFrame removed #1382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec parser was invoked with some arguments that it does not expect. This might be because it expects at least one argument, but in this case there were no changed files, only deleted ones, and the empty list of arguments is considered as a request for help. I'll think about it. |
sgrekhov
added a commit
to sgrekhov/co19
that referenced
this pull request
Aug 4, 2022
…art-lang#1382) Authored by @sgrekhov. Removes two tests that do not serve the stated purpose.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 11, 2022
2022-08-04 [email protected] dart-lang/co19#993. FFI tests refactored and improved (dart-lang/co19#1387) 2022-08-04 [email protected] dart-lang/co19#993. [FFI] Missed tests added for some new types (dart-lang/co19#1386) 2022-08-03 [email protected] Fixes dart-lang/co19#1129. Don't expect any proxy routine in case of DIRECT connection (dart-lang/co19#1383) 2022-08-03 [email protected] dart-lang/co19#993. [FFI] Missed tests added for some new types (dart-lang/co19#1384) 2022-07-29 [email protected] dart-lang/co19#673. IFrame tests that don't actually test IFrame removed (dart-lang/co19#1382) 2022-07-29 [email protected] dart-lang/co19#1363. Some delays removed or reduced (dart-lang/co19#1380) 2022-07-29 [email protected] dart-lang/co19#1363 Async `for-in` test updated according to the current specification (dart-lang/co19#1379) 2022-07-27 [email protected] dart-lang/co19#1363. Yield each tests updated to the current specification (dart-lang/co19#1374) 2022-07-27 [email protected] Fixes dart-lang/co19#1375. Add test for final variable in a for-in loop (dart-lang/co19#1378) 2022-07-25 [email protected] dart-lang/co19#1363. Tests for yield updated to the current specification (dart-lang/co19#1370) Change-Id: Ie92f4b2157284777177012320883247411e214fa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254140 Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigatint #673 found that these two test have nothing to do with
IFrameand can be safely removed. Seems that these tests are result of copy-paste fromElement