Skip to content

#993. [FFI] Missed tests added for some new types #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Aug 3, 2022

No description provided.

Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcharkes I have some questions, please see below

@sgrekhov
Copy link
Contributor Author

sgrekhov commented Aug 3, 2022

@dcharkes thank you. I made the changes the we've discussed. Please review

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eernstg eernstg merged commit 81a96e7 into dart-lang:master Aug 4, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this pull request Aug 4, 2022
…#1386)

Authored by @sgrekhov.

Missing tests added for some new types. Excessive test deleted, UintPtr fixed for 32-bit platforms.
@sgrekhov sgrekhov deleted the co19-993-2 branch August 9, 2022 10:19
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 11, 2022
2022-08-04 [email protected] dart-lang/co19#993. FFI tests refactored and improved (dart-lang/co19#1387)
2022-08-04 [email protected] dart-lang/co19#993. [FFI] Missed tests added for some new types (dart-lang/co19#1386)
2022-08-03 [email protected] Fixes dart-lang/co19#1129. Don't expect any proxy routine in case of DIRECT connection (dart-lang/co19#1383)
2022-08-03 [email protected] dart-lang/co19#993. [FFI] Missed tests added for some new types (dart-lang/co19#1384)
2022-07-29 [email protected] dart-lang/co19#673. IFrame tests that don't actually test IFrame removed (dart-lang/co19#1382)
2022-07-29 [email protected] dart-lang/co19#1363. Some delays removed or reduced (dart-lang/co19#1380)
2022-07-29 [email protected] dart-lang/co19#1363 Async `for-in` test updated according to the current specification (dart-lang/co19#1379)
2022-07-27 [email protected] dart-lang/co19#1363. Yield each tests updated to the current specification (dart-lang/co19#1374)
2022-07-27 [email protected] Fixes dart-lang/co19#1375. Add test for final variable in a for-in loop (dart-lang/co19#1378)
2022-07-25 [email protected] dart-lang/co19#1363. Tests for yield updated to the current specification (dart-lang/co19#1370)

Change-Id: Ie92f4b2157284777177012320883247411e214fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254140
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants