Skip to content

#1388. FFI test failures fixed #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Aug 9, 2022

No description provided.

@sgrekhov sgrekhov requested review from dcharkes and eernstg August 9, 2022 12:30
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take this opportunity to learn a bit more about how various number types are handled using FFI, so I can't yet comment on the PR as such.

Just one thing: I assume that the platform is the vm (no other platforms support FFI? yet?), and in that case it might be useful to consider int.toUnsigned: (-42).toUnsigned(32) yields the 64 bit zero extending interpretation of the bit pattern which is the 32 lowest bits of the representation of the receiver, so that's a way to get hold of (or check) those big numbers that arise because of signed/unsigned/32-bit/64-bit and whatnot conversions.

@eernstg
Copy link
Member

eernstg commented Aug 11, 2022

OK, I think this one is done. Landing.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit e1a272c into dart-lang:master Aug 11, 2022
@dcharkes
Copy link
Contributor

Just one thing: I assume that the platform is the vm (no other platforms support FFI? yet?), and in that case it might be useful to consider int.toUnsigned: (-42).toUnsigned(32) yields the 64 bit zero extending interpretation of the bit pattern which is the 32 lowest bits of the representation of the receiver, so that's a way to get hold of (or check) those big numbers that arise because of signed/unsigned/32-bit/64-bit and whatnot conversions.

That could indeed simplify this test. I learn something new every day!

sgrekhov added a commit to sgrekhov/co19 that referenced this pull request Aug 15, 2022
@sgrekhov sgrekhov deleted the co19-1388 branch September 2, 2022 06:43
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 12, 2022
2022-09-02 [email protected] dart-lang/co19#1399. on clause tests added (dart-lang/co19#1416)
2022-09-02 [email protected] dart-lang/co19#1399. [Records] Type annotations and record expressions tests updated (dart-lang/co19#1415)
2022-09-01 [email protected] Fixes dart-lang/co19#1398. Fix tests that use unreachable code after `Never` (dart-lang/co19#1402)
2022-08-31 [email protected] dart-lang/co19#1399. [Records] Typos in subtyping tests description fixed (dart-lang/co19#1414)
2022-08-31 [email protected] dart-lang/co19#1399. [Records] Subtyping tests for records added (dart-lang/co19#1412)
2022-08-31 [email protected] Fix typo (dart-lang/co19#1413)
2022-08-30 [email protected] dart-lang/co19#1405. BytesBuilder tests moved from dart:io to dart:typed_data (dart-lang/co19#1410)
2022-08-30 [email protected] dart-lang/co19#1399. Tests for record types. Part 1 (dart-lang/co19#1395)
2022-08-24 [email protected] dart-lang/co19#1405. Don't use deprecated API in co19 tests. Update generated files (dart-lang/co19#1407)
2022-08-24 [email protected] dart-lang/co19#1405. Don't use deprecated API in co19 tests (dart-lang/co19#1406)
2022-08-23 [email protected] Fixes dart-lang/co19#1361. Private fields promotion tests added (dart-lang/co19#1391)
2022-08-23 [email protected] Fixes dart-lang/co19#1394. Add missing compile-error (dart-lang/co19#1396)
2022-08-23 [email protected] Fixes dart-lang/co19#1403. Added test that `super` cannot be used as an expression (dart-lang/co19#1404)
2022-08-15 [email protected] dart-lang/co19#1388. FFI tests fixed for 32-bit systems (dart-lang/co19#1392)
2022-08-11 [email protected] dart-lang/co19#1388. FFI test failures fixed (dart-lang/co19#1389)

Change-Id: I2eee6c193eed1ce8a511f3ef5667ded947fbfad8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257700
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants