Fixes #1361. Private fields promotion tests added #1391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stereotype441
approved these changes
Aug 12, 2022
|
|
||
| void testC() { | ||
| if (_x != null) { | ||
| super._x.isOdd; |
There was a problem hiding this comment.
Ooh, nice corner case! My current prototype code doesn't handle it properly. I'll make sure to fix it :)
| /// @description Checks that if there are other concrete instance getters with | ||
| /// the same name in the same library and they are not a final fields then the | ||
| /// field is not promotable. Test the case when there is a getter with the same | ||
| /// name in some extension in the same library |
There was a problem hiding this comment.
Hmm, I had not thought about this case. I'm ok with leaving the test as is for now, but I've filed dart-lang/language#2404 to check if anyone on the language team feels strongly that this should behave differently.
|
@eernstg please review |
eernstg
approved these changes
Aug 23, 2022
|
|
||
| main() { | ||
| C(42).testC(); | ||
| } |
| } | ||
|
|
||
| class C { | ||
| int? get _x => 43; |
There was a problem hiding this comment.
For all these conflicts, perhaps test that there is no conflict when the "other" declaration that creates the conflict is static?
There was a problem hiding this comment.
Resolving: I think this is covered below already.
|
|
||
| void testA() { | ||
| if (_x is int) { | ||
| _x.isOdd; |
There was a problem hiding this comment.
This is probably just testing that we get a non-promotable getter when A._x isn't final (so it's probably an essentially-duplicate of an earlier test, and class C makes no difference ... but it isn't wrong).
|
|
||
| library promotion_A05_t10; | ||
|
|
||
| part "promotion_A05_t10.lib.dart"; |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 12, 2022
2022-09-02 [email protected] dart-lang/co19#1399. on clause tests added (dart-lang/co19#1416) 2022-09-02 [email protected] dart-lang/co19#1399. [Records] Type annotations and record expressions tests updated (dart-lang/co19#1415) 2022-09-01 [email protected] Fixes dart-lang/co19#1398. Fix tests that use unreachable code after `Never` (dart-lang/co19#1402) 2022-08-31 [email protected] dart-lang/co19#1399. [Records] Typos in subtyping tests description fixed (dart-lang/co19#1414) 2022-08-31 [email protected] dart-lang/co19#1399. [Records] Subtyping tests for records added (dart-lang/co19#1412) 2022-08-31 [email protected] Fix typo (dart-lang/co19#1413) 2022-08-30 [email protected] dart-lang/co19#1405. BytesBuilder tests moved from dart:io to dart:typed_data (dart-lang/co19#1410) 2022-08-30 [email protected] dart-lang/co19#1399. Tests for record types. Part 1 (dart-lang/co19#1395) 2022-08-24 [email protected] dart-lang/co19#1405. Don't use deprecated API in co19 tests. Update generated files (dart-lang/co19#1407) 2022-08-24 [email protected] dart-lang/co19#1405. Don't use deprecated API in co19 tests (dart-lang/co19#1406) 2022-08-23 [email protected] Fixes dart-lang/co19#1361. Private fields promotion tests added (dart-lang/co19#1391) 2022-08-23 [email protected] Fixes dart-lang/co19#1394. Add missing compile-error (dart-lang/co19#1396) 2022-08-23 [email protected] Fixes dart-lang/co19#1403. Added test that `super` cannot be used as an expression (dart-lang/co19#1404) 2022-08-15 [email protected] dart-lang/co19#1388. FFI tests fixed for 32-bit systems (dart-lang/co19#1392) 2022-08-11 [email protected] dart-lang/co19#1388. FFI test failures fixed (dart-lang/co19#1389) Change-Id: I2eee6c193eed1ce8a511f3ef5667ded947fbfad8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257700 Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.