#1363. Minor code improvement #1390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
approved these changes
Aug 10, 2022
eernstg
reviewed
Aug 10, 2022
| sent.forEach((element) { | ||
| Expect.isTrue([1, 2, 3].contains(element)); | ||
| }); | ||
| Expect.isTrue(sent.isNotEmpty); |
There was a problem hiding this comment.
This means that we will no longer detect if there's a bug (in tools or in the test) that makes element == 49283398?
Next, generator may suspend when a data event has been added to the returned stream, and this means that we could have [1] in sent, but we could also have [1, 2] or [1, 2, 3]. The test that we used to have verified that we have one of these possibilities except for the ordering, but the new code is considerably less precise.
I actually liked the old version better.
| sent.forEach((element) { | ||
| Expect.isTrue([1, 2, 3].contains(element)); | ||
| }); | ||
| Expect.isTrue(sent.length > 1); |
|
Let's leave it as it is now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @lrhn who noticed this