Skip to content

#1363. Minor code improvement #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

#1363. Minor code improvement #1390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t02.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ main() {
Expect.listEquals([1], readyToSend);
ss.resume();
await Future.delayed(Duration(milliseconds: 100));
// `sent` may contain not all elements of the stream
sent.forEach((element) {
Expect.isTrue([1, 2, 3].contains(element));
});
Expect.isTrue(sent.isNotEmpty);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that we will no longer detect if there's a bug (in tools or in the test) that makes element == 49283398?

Next, generator may suspend when a data event has been added to the returned stream, and this means that we could have [1] in sent, but we could also have [1, 2] or [1, 2, 3]. The test that we used to have verified that we have one of these possibilities except for the ordering, but the new code is considerably less precise.

I actually liked the old version better.

}
}, onDone: () {
Expect.listEquals([1, 2, 3], received);
Expand Down
5 changes: 1 addition & 4 deletions Language/Statements/Yield_and_Yield_Each/Yield/execution_async_A01_t08.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,7 @@ main() {
Expect.isTrue(sc.isPaused);
ss.resume();
await Future.delayed(Duration(milliseconds: 100));
// `sent` may contain not all elements of the stream
sent.forEach((element) {
Expect.isTrue([1, 2, 3].contains(element));
});
Expect.isTrue(sent.length > 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing.

}
if (i == 3) {
sc.close();
Expand Down