#2559. Add more tests for augmenting enum members and values. #2897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
LGTM!
One thing could be interesting to try out, but that doesn't have to delay this PR: Copy LanguageFeatures/Augmentation-libraries/augmenting_enum_values_A05_t04.dart. Then modify the copy such that every name declaration is static. This should be accepted, and it should still not be possible to invoke the extension getter name unless it is explicitly resolved as EnumName(myEnum).name. (That is: the static member with the same basename will suffice to shadow the extension member.)
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 4, 2024
2024-10-04 [email protected] Fixes dart-lang/co19#2919. Fix new roll failures (dart-lang/co19#2920) 2024-10-03 [email protected] dart-lang/co19#2915. Add missing extension in syntax_A03_t01.dart (dart-lang/co19#2918) 2024-10-03 [email protected] Fixes dart-lang/co19#2915. Fix errors and typos in some null-aware elements tests (dart-lang/co19#2917) 2024-10-03 [email protected] Fixes dart-lang/co19#2906. Add digit separators 'parse' tests (dart-lang/co19#2916) 2024-10-03 [email protected] Fixes dart-lang/co19#2907. Update expected errors positions in grammar_A03_t01.dart (dart-lang/co19#2914) 2024-10-02 [email protected] dart-lang/co19#2906. Add digit separators tests (dart-lang/co19#2910) 2024-10-02 [email protected] dart-lang/co19#2907. Revert wrong change in grammar_A04_t01_part1.dart (dart-lang/co19#2913) 2024-10-02 [email protected] Fixes dart-lang/co19#2907. Update expected errors positions in grammar_A04_t01_part1.dart (dart-lang/co19#2912) 2024-10-02 [email protected] Fixes dart-lang/co19#2909. Fix extension applicability tests according to the updated spec (dart-lang/co19#2911) 2024-10-01 49699333+dependabot[bot]@users.noreply.github.com Bump the github-actions group with 2 updates (dart-lang/co19#2908) 2024-10-01 [email protected] dart-lang/co19#2559. Add tests for adding body to static members (dart-lang/co19#2905) 2024-09-30 [email protected] Fixes dart-lang/co19#2902. Add tests for an extension applicability (dart-lang/co19#2903) 2024-09-30 [email protected] Fixes dart-lang/co19#2901. Update expected errors for analyzer and CFE (dart-lang/co19#2904) 2024-09-27 [email protected] dart-lang/co19#2559. Fix typo in augmenting_enum_values_A05_t05.dart (dart-lang/co19#2900) 2024-09-27 [email protected] dart-lang/co19#2559. Add test that `EnumName` extension is not augmentable (dart-lang/co19#2899) 2024-09-27 [email protected] dart-lang/co19#2559. Add more tests for augmenting enum members and values. (dart-lang/co19#2897) 2024-09-27 [email protected] dart-lang/co19#2825. Add more grammar and terminology tests (dart-lang/co19#2885) 2024-09-27 [email protected] dart-lang/co19#2559. Fix accidental syntax errors (dart-lang/co19#2898) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Id70baf6e0f6a6ea62eb0b507bffc3c1fb39e71ce Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388007 Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.