-
Notifications
You must be signed in to change notification settings - Fork 125
"Enter" to see full search results doesn't work #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Reproduces on https://api.dart.dev/be/187340/index.html? |
Sadly, this seems unfixed. For reasons I do not understand! |
FWIW, this doesn't work on https://master-api.flutter.dev/ as far as I can tell. I don't know what version of dartdoc that's on though, maybe we just haven't rolled far enough yet? |
It's on latest – 6.1.2 – it IS working on https://api.dart.dev/be/ Wondering if the JS is copied or modified with Flutter... |
We have a regular (semi-automated) process to roll the latest dartdoc into the dart sdk. My most recent knowledge here (which may be out of date) is that it's a manual process to roll the latest dartdoc into flutter. |
Ah; last updated (by @kevmoo) ~15 days ago: https://github.com/flutter/flutter/blob/master/dev/bots/docs.sh. |
...but there was ALSO some concern that the way flutter rolls dartdoc is non-standard. maybe the JS files are different than what's in the package, etc. |
It's also weird that https://master-api.flutter.dev/search.html does not load. That could be related, as that is what pressing Enter will load. |
This is not working on the Flutter API docs. Any chance we could reopen the issue and make it a high priority? We're about to have a significant branch cut. |
If I press enter after typing in a search term with many results, I get a UI that says to press Enter to get all the results.
However, nothing happens when I press enter.
The text was updated successfully, but these errors were encountered: