Skip to content

"Enter" to see full search results doesn't work #3172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hixie opened this issue Sep 19, 2022 · 11 comments · Fixed by #3185, #3195 or #3256
Closed

"Enter" to see full search results doesn't work #3172

Hixie opened this issue Sep 19, 2022 · 11 comments · Fixed by #3185, #3195 or #3256
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@Hixie
Copy link
Contributor

Hixie commented Sep 19, 2022

If I press enter after typing in a search term with many results, I get a UI that says to press Enter to get all the results.

However, nothing happens when I press enter.

@kevmoo
Copy link
Member

kevmoo commented Sep 22, 2022

Reproduces on https://api.dart.dev/be/187340/index.html?

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) feature: new search P1 A high priority bug; for example, a single project is unusable or has many test failures labels Sep 22, 2022
@kevmoo kevmoo self-assigned this Sep 26, 2022
@kevmoo
Copy link
Member

kevmoo commented Sep 27, 2022

Sadly, this seems unfixed. For reasons I do not understand!

@Hixie
Copy link
Contributor Author

Hixie commented Oct 14, 2022

FWIW, this doesn't work on https://master-api.flutter.dev/ as far as I can tell. I don't know what version of dartdoc that's on though, maybe we just haven't rolled far enough yet?

@kevmoo
Copy link
Member

kevmoo commented Oct 14, 2022

It's on latest – 6.1.2 – it IS working on https://api.dart.dev/be/

Wondering if the JS is copied or modified with Flutter...

@devoncarew
Copy link
Member

We have a regular (semi-automated) process to roll the latest dartdoc into the dart sdk. My most recent knowledge here (which may be out of date) is that it's a manual process to roll the latest dartdoc into flutter.

@devoncarew
Copy link
Member

@kevmoo
Copy link
Member

kevmoo commented Oct 14, 2022

...but there was ALSO some concern that the way flutter rolls dartdoc is non-standard. maybe the JS files are different than what's in the package, etc.

@srawlins
Copy link
Member

It's also weird that https://master-api.flutter.dev/search.html does not load. That could be related, as that is what pressing Enter will load.

@Hixie
Copy link
Contributor Author

Hixie commented Dec 3, 2022

This is not working on the Flutter API docs. Any chance we could reopen the issue and make it a high priority? We're about to have a significant branch cut.

cc @itsjustkevin @gspencergoog

@kevmoo
Copy link
Member

kevmoo commented Dec 3, 2022

Yeah, we need this fixed. @keertip @srawlins @jacob314

@srawlins srawlins reopened this Dec 3, 2022
parlough added a commit to parlough/dartdoc that referenced this issue Dec 4, 2022
parlough added a commit to parlough/dartdoc that referenced this issue Dec 4, 2022
srawlins pushed a commit that referenced this issue Dec 4, 2022
@itsjustkevin
Copy link

FYI @atsansone @MaryaBelanger

@srawlins srawlins mentioned this issue Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
5 participants