Fix error when using head base-href #3256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
changed the title
parlough
force-pushed
the
fix/error-when-using-base-href
branch
from
c30a8df to
4119fba
Compare
|
This base href stuff freaks me out. It affects all links, so requires a lot of test coverage, which we don't have, combinatorically speaking. :/ Also we don't have web tests. #3027 |
|
Approving past the existing linter breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
data-using-base-hrefistrue, that means it is using thebaseelement to set href, not that it is using ahrefattribute on thebodyelement. To support using the href specified there, we also need to properly use an actual relative path instead of basing it on the fullwindow.location.href.Fixes #3172