Skip to content

Reorder categories and fix enum masthead links #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2017
Merged

Conversation

jcollins-g
Copy link
Contributor

This addresses #1323 and #1225.

@jcollins-g jcollins-g requested a review from devoncarew April 13, 2017 20:59
@googlebot googlebot added the cla: yes Google CLA check succeeded. label Apr 13, 2017
@devoncarew
Copy link
Member

devoncarew commented Apr 14, 2017

lgtm!

In several places it looks like dartfmt has split a one line if statement; so:

if (foo) bar();

into:

if (foo)
  bar();

which is correct given the line length, but I believe Dart's style prefers to use curlies braces for if statements (unless the whole if statement can fit on one line).

So, instead:

if (foo) {
  bar();
}

https://www.dartlang.org/guides/language/effective-dart/style#do-use-curly-braces-for-all-flow-control-structures

@jcollins-g jcollins-g requested a review from keertip April 14, 2017 15:10
Copy link
Collaborator

@keertip keertip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jcollins-g jcollins-g merged commit 5c9f166 into master Apr 14, 2017
@jcollins-g jcollins-g deleted the category-reordering branch April 14, 2017 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants