Skip to content

Allow references to generic type aliases #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcollins-g
Copy link
Contributor

@jcollins-g jcollins-g commented Mar 18, 2021

Fixes #2499.

This is the last bit needed for generic type aliases. With the exception of void and other singletons in the analyzer (see dart-lang/sdk#45291) this allows dartdoc to reference aliases by their name and type parameters rather than the underlying type.

Screen Shot 2021-03-18 at 10 48 14 AM

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Mar 18, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 91.26% when pulling 0b2f932 on jcollins-g:modelType-refactor+type-alias-referencing into 7022b7f on dart-lang:master.

@jcollins-g jcollins-g requested review from srawlins and scheglov March 18, 2021 18:17
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -7,7 +7,7 @@ environment:
sdk: '>=2.11.99 <3.0.0'

dependencies:
analyzer: ^1.1.0
analyzer: ^1.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@jcollins-g jcollins-g merged commit 0a83b0f into dart-lang:master Mar 18, 2021
@jcollins-g jcollins-g deleted the modelType-refactor+type-alias-referencing branch March 18, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add generic type aliases to dartdoc
4 participants