Skip to content

Versionify static assets #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2021

Conversation

jcollins-g
Copy link
Contributor

By adding a "query" with a version string, we can force browsers to reload cached static assets when they change between versions of dartdoc. This is most interesting for users who are generating docs with non-unique URIs.

cc @goderbauer

@jcollins-g jcollins-g requested a review from srawlins May 18, 2021 17:57
@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label May 18, 2021
@jcollins-g
Copy link
Contributor Author

Adding @CaptainIRS as their PR #2621 made the lack of this really obvious on https://master-api.flutter.dev when Flutter was updated -- browsers were using old style sheets with new content in some instances.

@coveralls
Copy link

coveralls commented May 18, 2021

Coverage Status

Coverage remained the same at 57.781% when pulling 9c0a3f1 on jcollins-g:versionify-static-assets into b8958f9 on dart-lang:master.

@CaptainIRS
Copy link
Contributor

Adding @CaptainIRS as their PR #2621 made the lack of this really obvious on https://master-api.flutter.dev when Flutter was updated -- browsers were using old style sheets with new content in some instances.

ACK. The docs would've appeared broken if the flex order change in the stylesheet hadn't loaded properly. Glad it's getting fixed!

@jcollins-g jcollins-g merged commit 6b957de into dart-lang:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants