Skip to content

Versionify static assets #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/resources/script.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
*
* Update script.js versions in all lib/templates when modifying this file!
*
*/
function initSideNav() {
const leftNavToggle = document.getElementById('sidenav-left-toggle');
const leftDrawer = document.querySelector('.sidebar-offcanvas-left');
Expand Down
5 changes: 5 additions & 0 deletions lib/resources/styles.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
*
* Update styles.css versions in all lib/templates when modifying this file!
*
*/

/* Palette generated by Material Palette - materialpalette.com/blue/cyan */

Expand Down
5 changes: 3 additions & 2 deletions lib/templates/html/_footer.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
</footer>

{{! TODO(jdkoren): unwrap ^useBaseHref sections when the option is removed.}}
<script src="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/highlight.pack.js"></script>
<script src="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/script.js"></script>
{{! **Update versions for static assets when changed to force browsers to refresh them.** }}
<script src="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/highlight.pack.js?v1"></script>
<script src="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/script.js?v1"></script>

{{{ customFooter }}}

Expand Down
7 changes: 4 additions & 3 deletions lib/templates/html/_head.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@
<link rel="preconnect" href="https://fonts.gstatic.com">
<link href="https://fonts.googleapis.com/css2?family=Roboto+Mono:ital,wght@0,300;0,400;0,500;0,700;1,400&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
<link rel="stylesheet" href="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/github.css">
<link rel="stylesheet" href="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/styles.css">
<link rel="icon" href="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/favicon.png">
{{! **Update versions for static assets when changed to force browsers to refresh them.** }}
<link rel="stylesheet" href="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/github.css?v1">
<link rel="stylesheet" href="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/styles.css?v1">
<link rel="icon" href="{{^useBaseHref}}%%__HTMLBASE_dartdoc_internal__%%{{/useBaseHref}}static-assets/favicon.png?v1">

{{{ customHeader }}}
</head>
Expand Down