-
Notifications
You must be signed in to change notification settings - Fork 380
[web_socket] Adds WebSocketException.toString()
#1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web_socket] Adds WebSocketException.toString()
#1756
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ❗
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with
Coverage
|
File | Coverage |
---|---|
pkgs/web_socket/lib/src/web_socket.dart | 💔 54 % ⬇️ 11 % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/http/example/main.dart |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/95105e9..e4f9451): e4f9451a 2025-05-05 Jonas Finnemann Jensen Fix duplicate entries of elements in a category when re-exported. (dart-lang/dartdoc#4043) 876180bd 2025-05-01 dependabot[bot] Bump github/codeql-action from 3.28.13 to 3.28.16 in the github-actions group (dart-lang/dartdoc#4045) http (https://github.com/dart-lang/http/compare/63c477b..78d6114): 78d6114 2025-05-02 Brian Quinlan Add a new exception type `NSErrorClientException` (dart-lang/http#1763) 7a2e7d5 2025-05-01 Brian Quinlan Add a useful stringificiation to `WebSocketConnectionClosed` (dart-lang/http#1764) ccb6533 2025-05-01 dependabot[bot] Bump the github-actions group across 1 directory with 4 updates (dart-lang/http#1761) 7568b5c 2025-05-02 Alex Li [web_socket] Adds `WebSocketException.toString()` (dart-lang/http#1756) 3e4cceb 2025-05-01 Brian Quinlan Make response headers tests pass on firefox (dart-lang/http#1762) 5704b0c 2025-05-01 Brian Quinlan [cronet_http/cupertino_http]: Fixes bugs where cancelling `StreamedResponse.stream` did not sever the connection (dart-lang/http#1760) test (https://github.com/dart-lang/test/compare/c3755d8..55d1f9e): 55d1f9ed 2025-05-05 Fichtelcoder Fix typos in json_reporter documentation (dart-lang/test#2493) vector_math (https://github.com/google/vector_math.dart/compare/39cafd4..0279cb8): 0279cb8 2025-05-01 Ömer Sinan Ağacan Improve performance of functions with dynamic arguments (google/vector_math.dart#345) Change-Id: I9a67b997ebcf7ebe29162f8f524628013d53af5a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426581 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
Similar to
WebSocketChannelException
andClientException
, overriding the method would provide a readable format when referencing it in logs/consoles.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.